base: fix xx-info failing on macOS #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macOS doesn't have a /etc/os-release, which caused the script to fail when running on the host. Also adds detection if /etc/os-release exists. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
fix_vendor_macos
branch
from
c5f2a6a
to
eac387d
Compare
thaJeztah
changed the title
|
removed the bit about "unknown", as it was already initialised to "unknown" by default |
thaJeztah
commented
Jul 7, 2022
| @@ -328,7 +328,7 @@ case "$1" in | |||
| echo $XX_TRIPLE | |||
| ;; | |||
| "vendor") | |||
| echo $XX_VENDOR | |||
| echo "$XX_VENDOR" | |||
There was a problem hiding this comment.
validate was complaining about this one not being quoted (not sure why it only complains about this one, and not the other ones 🤷♂️
There was a problem hiding this comment.
yes this one is strange, looks good now.
trilom
pushed a commit
to trailmix/xx
that referenced
this pull request
Sep 9, 2022
base: fix xx-info failing on macOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
macOS doesn't have a /etc/os-release, which caused the script to fail
when running on the host.
Also adds detection if /etc/os-release exists,.