Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an example of the readability of minified code #223

Closed
wants to merge 2 commits into from

Conversation

NewAlexandria
Copy link

I found that FiraCode dramaticaly improves the readability of minified javascript blocks.

I added an example, and included it in the README.md.

I also added anchor links to the examples.

Best, and thanks for any feedback

@tonsky
Copy link
Owner

tonsky commented Jul 21, 2016

Thanks! That’s a nice use case. I think, however, that in your example syntax highlighting contributes much more to the readability than ligatures do

@tonsky tonsky closed this Jul 21, 2016
@NewAlexandria
Copy link
Author

NewAlexandria commented Jul 21, 2016

I think that FiraCode is the major contributor here (yes, in addition to coloration and ligatures)

I can upload this same example of this in other fonts.

I agree that the placement in the README is a little different than I considered. Those other screenshots are really just for showing the ligatures, even though they are generically listed as examples.

I understand that the ligature control is a major dimension of FiraCode, but I think this screenshot shows how the font is more than that, especially with coloration.

Losangelosgenetics pushed a commit to Losangelosgenetics/FiraCode that referenced this pull request Mar 12, 2020
199: Update rack-test requirement from ~> 0.6 to ~> 1.1 r=bronzdoc a=dependabot[bot]

Updates the requirements on [rack-test](https://github.com/rack-test/rack-test) to permit the latest version.
<details>
<summary>Release notes</summary>

*Sourced from [rack-test's releases](https://github.com/rack-test/rack-test/releases).*

> ## v1.1.0
> ## 1.1.0 / 2018-07-21
> 
> * Breaking changes:
>   * None
> 
> * Minor enhancements / new functionality:
>   * [GitHub] Added configuration for Stale (Per Lundberg [tonsky#232](https://github-redirect.dependabot.com/rack-test/rack-test/issues/232))
>   * `follow_direct`: Include `rack.session.options` (Mark Edmondson [tonsky#233](https://github-redirect.dependabot.com/rack-test/rack-test/issues/233))
>   * [CI] Add simplecov (fatkodima [tonsky#227](https://github-redirect.dependabot.com/rack-test/rack-test/issues/227))
> 
> Bug fixes:
>   * Follow relative locations correctly. (Samuel Williams [tonsky#230](https://github-redirect.dependabot.com/rack-test/rack-test/issues/230))
</details>
<details>
<summary>Changelog</summary>

*Sourced from [rack-test's changelog](https://github.com/rack-test/rack-test/blob/master/History.md).*

> ## 1.1.0 / 2018-07-21
> 
> * Breaking changes:
>   * None
> 
> * Minor enhancements / new functionality:
>   * [GitHub] Added configuration for Stale (Per Lundberg [tonsky#232](https://github-redirect.dependabot.com/rack-test/rack-test/issues/232))
>   * follow_direct: Include rack.session.options (Mark Edmondson [tonsky#233](https://github-redirect.dependabot.com/rack-test/rack-test/issues/233))
>   * [CI] Add simplecov (fatkodima [tonsky#227](https://github-redirect.dependabot.com/rack-test/rack-test/issues/227))
> 
> Bug fixes:
>   * Follow relative locations correctly. (Samuel Williams [tonsky#230](https://github-redirect.dependabot.com/rack-test/rack-test/issues/230))
> 
> ## 1.0.0 / 2018-03-27
> 
> * Breaking changes:
>   * Always set CONTENT_TYPE for non-GET requests
>     (Per Lundberg [tonsky#223](https://github-redirect.dependabot.com/rack-test/rack-test/issues/223))
> 
> * Minor enhancements / bug fixes:
>   * Create tempfile using the basename without extension
>     (Edouard Chin [tonsky#201](https://github-redirect.dependabot.com/rack-test/rack-test/issues/201))
>   * Save `session` during `follow_redirect!`
>     (Alexander Popov [tonsky#218](https://github-redirect.dependabot.com/rack-test/rack-test/issues/218))
>   * Document how to use URL params with DELETE method
>     (Timur Platonov [tonsky#220](https://github-redirect.dependabot.com/rack-test/rack-test/issues/220))
> 
> ## 0.8.3 / 2018-02-27
> 
> * Bug fixes:
>   * Do not set Content-Type if params are explicitly set to nil
>     (Bartek Bułat [tonsky#212](https://github-redirect.dependabot.com/rack-test/rack-test/issues/212)). Fixes [tonsky#200](https://github-redirect.dependabot.com/rack-test/rack-test/issues/200).
>   * Fix `UploadedFile#new` regression
>     (Per Lundberg [tonsky#215](https://github-redirect.dependabot.com/rack-test/rack-test/issues/215))
> 
> * Minor enhancements
>   * [CI] Test against Ruby 2.5 (Nicolas Leger [tonsky#217](https://github-redirect.dependabot.com/rack-test/rack-test/issues/217))
> 
> ## 0.8.2 / 2017-11-21
> 
> * Bug fixes:
>   * Bugfix for `UploadedFile.new` unintended API breakage.
>     (Per Lundberg [tonsky#210](https://github-redirect.dependabot.com/rack-test/rack-test/issues/210))
> 
> ## 0.8.0 / 2017-11-20
> 
> * Known Issue
>   * In `UploadedFile.new`, when passing e.g. a `Pathname` object,
>     errors can be raised (eg. `ArgumentError: Missing original_filename
>     for IO`, or `NoMethodError: undefined method 'size'`) See [tonsky#207](https://github-redirect.dependabot.com/rack-test/rack-test/issues/207), [tonsky#209](https://github-redirect.dependabot.com/rack-test/rack-test/issues/209).
></table> ... (truncated)
</details>
<details>
<summary>Commits</summary>

- See full diff in [compare view](https://github.com/rack-test/rack-test/commits/v1.1.0)
</details>
<br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

**Note:** This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking `Bump now` in your [Dependabot dashboard](https://app.dependabot.com).

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot ignore this [patch|minor|major] version` will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
- `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com):
- Update frequency (including time of day and day of week)
- Automerge options (never/patch/minor, and dev/runtime dependencies)
- Pull request limits (per update run and/or open at any time)
- Out-of-range updates (receive only lockfile updates, if desired)
- Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

</details>

Co-authored-by: dependabot[bot] <support@dependabot.com>
Losangelosgenetics pushed a commit to Losangelosgenetics/FiraCode that referenced this pull request Mar 12, 2020
223: Add a failing Aruba-based RSpec test for the CLI client output r=[bronzdoc] a=olleolleolle

This Draft PR is about showing what [Aruba](https://github.com/cucumber/aruba/) can do for testing the CLI client output.

## TODO

- [x] Get some known-good output to assert against

Co-authored-by: Olle Jonsson <olle.jonsson@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants