Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor/tmux-mem-cpu-load should follow branch #13

Closed
zembrowski opened this issue Apr 18, 2015 · 3 comments
Closed

vendor/tmux-mem-cpu-load should follow branch #13

zembrowski opened this issue Apr 18, 2015 · 3 comments

Comments

@zembrowski
Copy link

Hi Tony,

could you set the tmux-mem-cpu-load submodule to follow the master branch of https://github.com/thewtex/tmux-mem-cpu-load?

Alternatively you could change one line in the README:

git submodule update --remote

You see the args changed in the tmux.conf for tmux-mem-cpu-load with commit 0d6943e, but the submodule follows an old version. Therefore, on a fresh install tmux-mem-cpu-load doesn't seem to work. Might be frustrating for a new user.

Thank you in advance.

Best regards,
Krzysztof

@tony
Copy link
Owner

tony commented May 5, 2015

Hey @zembrowski! That sounds like a plan!, would you like to submit a pull request for it?

@tony
Copy link
Owner

tony commented Oct 24, 2015

I apologize for the late response.

I updated the version of tmux-mem-cpu-load to v3.2.2.

If we switch to the submodule to follow master, the instructions the README provides could fall out of sync. The command inside .tmux.conf would also need to be updated manually by the user.

We could add instructions on how to use the latest tmux-mem-cpu-load and refer them to tmux-mem-cpu-load's documentation.

What do you think?

@zembrowski
Copy link
Author

Hi Tony,

Thanks for the response.

The issue I described back in April was that on a fresh install tmux-mem-cpu-load didn't work out-of-the-box following the README instruction.

Tried it now on a new install and it works like a charm, so problem solved.

And yes, you are right - there should be an instruction on how to use the lastest tmux-mem-cpu-load module. Additionally it would be very good to update the submodule on a regular basis and check if any adjustments in the .tmux.conf are necessary.

Best regards,
Krzysztof

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants