[ABI] remove channel validation from image API implementations #505
Labels
topic branch
implemented in a topic branch
Comments
tonycoz
added a commit
that referenced
this issue
Mar 18, 2023
For simple calls, such as by i_ppix() etc, these would form a significant part of the execution time for their call. Debug builds continue to assert on such errors. The XS wrappers in Imager.xs now do the channel list validation, so callers from perl won't be able to produce undefined behaviour. Fixes #505
tonycoz
added a commit
that referenced
this issue
Dec 2, 2023
For simple calls, such as by i_ppix() etc, these would form a significant part of the execution time for their call. Debug builds continue to assert on such errors. The XS wrappers in Imager.xs now do the channel list validation, so callers from perl won't be able to produce undefined behaviour. Fixes #505
tonycoz
added a commit
that referenced
this issue
Dec 26, 2023
For simple calls, such as by i_ppix() etc, these would form a significant part of the execution time for their call. Debug builds continue to assert on such errors. The XS wrappers in Imager.xs now do the channel list validation, so callers from perl won't be able to produce undefined behaviour. Fixes #505
tonycoz
added a commit
that referenced
this issue
Mar 24, 2024
For simple calls, such as by i_ppix() etc, these would form a significant part of the execution time for their call. Debug builds continue to assert on such errors. The XS wrappers in Imager.xs now do the channel list validation, so callers from perl won't be able to produce undefined behaviour. Fixes #505
tonycoz
added a commit
that referenced
this issue
Mar 25, 2024
For simple calls, such as by i_ppix() etc, these would form a significant part of the execution time for their call. Debug builds continue to assert on such errors. The XS wrappers in Imager.xs now do the channel list validation, so callers from perl won't be able to produce undefined behaviour. Fixes #505
tonycoz
added a commit
that referenced
this issue
Apr 14, 2024
For simple calls, such as by i_ppix() etc, these would form a significant part of the execution time for their call. Debug builds continue to assert on such errors. The XS wrappers in Imager.xs now do the channel list validation, so callers from perl won't be able to produce undefined behaviour. Fixes #505
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Still add assertions for validity, but the checks add significant overhead to small requests.
The XS entry points will still do their own validation.
The text was updated successfully, but these errors were encountered: