Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Withdraw the Ubuntu images #84

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Withdraw the Ubuntu images #84

merged 1 commit into from
Jan 22, 2024

Conversation

debarshiray
Copy link
Contributor

Toolbx now offers built-in support for Ubuntu and these images are maintained as part of the Toolbx project.

#81

@debarshiray debarshiray mentioned this pull request Jun 8, 2023
Closed
travier
travier reviewed Jun 8, 2023
View reviewed changes
Copy link
Member

@travier travier left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit but LGTM.

README.md Show resolved Hide resolved
travier
travier reviewed Jun 8, 2023
View reviewed changes
Copy link
Member

@travier travier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's hold until everything is setup in toolbx

@debarshiray
Copy link
Contributor Author

LGTM. Let's hold until everything is setup in toolbx

The Ubuntu images from quay.io/toolbx/... should be ready for general consumption and the toolbox(1) code has been updated.

@travier
Copy link
Member

travier commented Jun 9, 2023

Let's wait until there is at least a release of toolbox with that change and then I'll delete the repo as well.

@debarshiray
Copy link
Contributor Author

then I'll delete the repo as well.

You could also leave the Quay.io repo for a while longer. Some people might have the URLs in their scripts and shell history and what not.

@travier
Copy link
Member

travier commented Jun 9, 2023 •
edited
Loading

I'm tempted to make it fail hard fast so that users move to the new location as the old one won't be updated anymore.

@debarshiray
Copy link
Contributor Author

I'm tempted to make it fail hard fast so that users move to the new location as the old one won't be updated anymore.

Okay, that makes sense, yes.

@debarshiray
Copy link
Contributor Author

Let's wait until there is at least a release of toolbox with that change and then I'll delete the repo as well.

We now have a new Toolbx release that offers built-in support for Ubuntu and it's slowly making it's way to various distributions.

@debarshiray debarshiray force-pushed the wip/rishi/remove-ubuntu branch 3 times, most recently from 67e9c2a to 20b0ff1 Compare January 16, 2024 23:34
travier
travier reviewed Jan 18, 2024
View reviewed changes
Copy link
Member

@travier travier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll wait a few weeks to let the new toolbox land in distros and then we can merge this.

@debarshiray
Copy link
Contributor Author

LGTM. I'll wait a few weeks to let the new toolbox land in distros and then we can merge this.

Cool.

@juhp
Copy link

juhp commented Jan 19, 2024 •
edited
Loading

Unfortunately looks like the deb distro packages are far (1 year) behind: https://repology.org/project/go:github-containers-toolbox/versions

@travier
Copy link
Member

travier commented Jan 19, 2024

Maybe we can add the full URLs as well in the README for compatibility with older toolbox versions? Then we could probably merge this directly.

@debarshiray
Withdraw the Ubuntu images
048c385 
Toolbx now offers built-in support for Ubuntu and these images are
maintained as part of the Toolbx project.

toolbx-images#81
@debarshiray
Copy link
Contributor Author

Maybe we can add the full URLs as well in the README for compatibility with older toolbox versions? Then we could probably merge this directly.

Done.

I left the stanza with the new --distro usage, and added a new one to show the alternative with --image for compatibility with older Toolbx versions.

@travier travier mentioned this pull request Jan 22, 2024
Closed
@travier
Copy link
Member

travier commented Jan 22, 2024

Looks good. The images are not cosign-signed but we can improve that in the toolbox repo workflows.

@travier travier merged commit 3417454 into toolbx-images:main Jan 22, 2024
@travier travier mentioned this pull request Jan 22, 2024
Merged
@debarshiray
Copy link
Contributor Author

The images are not cosign-signed but we can improve that in the toolbox repo workflows.

It will be good to have the built-in Arch Linux and Ubuntu images signed.

@debarshiray debarshiray deleted the wip/rishi/remove-ubuntu branch January 24, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travier travier travier approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@debarshiray @travier @juhp