Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footway/Service road permissions #42

Merged
merged 3 commits into from
Mar 20, 2020
Merged

Footway/Service road permissions #42

merged 3 commits into from
Mar 20, 2020

Conversation

spencerrecneps
Copy link
Contributor

Allows bicycle use on footways and service roads where bicycle tag is "yes", "permissive", or "designated".

@spencerrecneps
Copy link
Contributor Author

These changes mimic the changes made here:
azavea/pfb-network-connectivity#785

@beckymasond one thing I wanted to run past you. In the original code I had a constraint that only allowed footways to be used if they were explicitly tagged at least 8 feet wide. I carried this through in pybna, but this dramatically reduces the footways that get assigned as paths. I've removed the width constraint in this PR, which I think matches the current practice in the production BNA system.

The intent behind the width constraint, as well as only allowing bicycle=designated, was basically to prevent sidewalks from being credited for bike connectivity unless the sidewalks are very wide and explicitly included in the bike network.

Do you have thoughts about this? I can reintroduce if you want something in there.

@beckymasond
Copy link
Collaborator

beckymasond commented Mar 19, 2020

The main goal of expanding the footway and service tags was to ensure that the value "yes" is considered acceptable like "designated," since users brought me instances of service roads and footways that are bike-friendly being left out of the analysis for that reason and it caused some confusion. I left the width requirement in the functional_class script in the original BNA so it still retains that stringency, and I agree that it makes sense to leave that width requirement in for the reasons you mentioned.

@spencerrecneps spencerrecneps merged commit 776c885 into dev Mar 20, 2020
@spencerrecneps spencerrecneps deleted the permissions branch March 20, 2020 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants