This repository has been archived by the owner on Feb 26, 2019. It is now read-only.
Handle lines longer than 64k #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 16, 2015 15:32
A lot of people who vendor files in []byte seems to run into this problem.
| if err != nil { | ||
| return err | ||
| if err == io.EOF { |
There was a problem hiding this comment.
It would be pretty cool to pull this out in front of the surrounding if stmt:
l, err := b.ReadBytes('\n')
eof := err == io.EOF
if err != nil && err != io.EOF {
return err
}This is a bit cleaner.
|
@kr Done. If it LGTY, then I'll merge it. |
| } | ||
| } | ||
|
|
||
| // If we're at the EOF exit |
There was a problem hiding this comment.
The comments in this function don't really add anything meaningful. I would delete them.
freeformz
pushed a commit
that referenced
this pull request
Jun 17, 2015
Handle lines longer than 64k
This was referenced Jun 17, 2015
|
+1 LGTM |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle lines longer than 64k.
/cc @kr #228 #160 #179