This repository has been archived by the owner on Feb 26, 2019. It is now read-only.
Change up how download/restore works a little #362
Merged
+112
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freeformz
changed the title
Closed
|
I tested this change + kubernetes/kubernetes#18706 and kube is once again happy! |
Open
freeformz
force-pushed
the
fix_up_restore_p1
branch
2 times, most recently
from
404df67
to
03595ab
Compare
* Try to load the package after downloading/restoring. Previously that was done too early in the process. * make previous verbose output debug output * report a typed error instead of a string from listPackage so it can be asserted to provide a nicer error. * Catch go get errors that say there are no go files found. See code comment as to why. * do *all* downloading during download phase.
eparis
added a commit
to eparis/kubernetes
that referenced
this pull request
Jan 5, 2016
This reverts commit 7d5acfb. This was hopefully fixed in tools/godep#362
vishh
pushed a commit
to vishh/kubernetes
that referenced
this pull request
Mar 18, 2016
This reverts commit 7d5acfb. This was hopefully fixed in tools/godep#362
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we did that too early in the process.
assert and provide a nicer error.
comment as to why.