This repository has been archived by the owner on Feb 26, 2019. It is now read-only.
Ignore .go files when checking for license/legal #384
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current heuristic for license or legal files is a little broad
because it will inadvertently sweep up go source files that shouldn't be
vendored. As one example, when trying to vendor the package
github.com/camlistore/go4/errorutil
,godep save
also brings in thefile
github.com/camlistore/go4/blob/master/legal/legal.go
.This patch changes the
IsLicenseFile
andIsLegalFile
checks toimmediately return false if the filename ends in
.go
.