Replace LF with CRLF #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emails fail validation due to "bad mail format", which is caused by loss of CRLFs somewhere in the data pipeline when a raw email is downloaded. This PR attempts to fix this problem by replacing all LFs with CRLFs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Emails fail validation due to "bad mail format", which is caused by loss of CRLFs somewhere in the data pipeline when a raw email is downloaded for testing this library. This PR attempts to fix this problem by replacing all LFs with CRLFs as was noted in the TODO tag on line 537 of dkim.go
While I don't completely understand where in the pipeline the problem is occurring, I am opening this PR to bring attention to this problem and begin solving it with your help.