fix issue #11, segfault in shine_BF_freePartHolder #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
config->formatbits.side_info.headerPH and config->formatbits.side_info.frameSIPH are allocated at the same time thus checking one of them should be sufficient to ensure that an unsafe free is not performed. Other solutions would be to check for NULL in shine_BF_freePartHolder, but this is faster.
toots
added a commit
that referenced
this pull request
Mar 29, 2014
fix issue #11, segfault in shine_BF_freePartHolder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
config->formatbits.side_info.headerPH and
config->formatbits.side_info.frameSIPH are allocated at the same time
thus checking one of them should be sufficient to ensure that an unsafe
free is not performed. Other solutions would be to check for NULL in
shine_BF_freePartHolder, but this is faster.