fix issue #11, segfault in shine_BF_freePartHolder #12

Merged
merged 1 commit into from Mar 29, 2014

Conversation

Projects
None yet
2 participants
Contributor

felixmulder commented Jan 17, 2014

config->formatbits.side_info.headerPH and
config->formatbits.side_info.frameSIPH are allocated at the same time
thus checking one of them should be sufficient to ensure that an unsafe
free is not performed. Other solutions would be to check for NULL in
shine_BF_freePartHolder, but this is faster.

@felixmulder felixmulder fix issue #11, segfault in shine_BF_freePartHolder
config->formatbits.side_info.headerPH and
config->formatbits.side_info.frameSIPH are allocated at the same time
thus checking one of them should be sufficient to ensure that an unsafe
free is not performed. Other solutions would be to check for NULL in
shine_BF_freePartHolder, but this is faster.
0a5bfc0

toots merged commit 7c6b529 into toots:master Mar 29, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment