Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add number of notifications as badge to notifications tab title #710

Closed
ghost opened this issue Apr 1, 2017 · 11 comments
Closed

Add number of notifications as badge to notifications tab title #710

ghost opened this issue Apr 1, 2017 · 11 comments
Labels
ui Front-end, design

Comments

@ghost
Copy link

ghost commented Apr 1, 2017

single column mode is very well implemented i think, except for a single flaw, most people do not want to spend the majority of their time in their notifications window, but otherwise you cant at a glance look whether you have notifications when the sound is off

2017-03-31_23-04-22

i would suggest adding a "badge" as they're called in windows ten, when on a taskbar button, with the number of notifications, right over the button that takes you to the notifications column

@ashfurrow ashfurrow changed the title better notifications in single column mode Add number of notifications as badge to notifications tab title Apr 22, 2017
@ashfurrow ashfurrow added enhancement ui Front-end, design labels Apr 22, 2017
@joyeusenoelle
Copy link
Contributor

joyeusenoelle commented May 5, 2017

I'll take a look at this and see what I can do.

Issues that come immediately to mind:

  • Can this be done without actually fetching the mentions?
    • If so, can it tell the difference between total mentions and mentions that aren't included in the column?
  • Can this be enabled by user preference rather than being the only/default behavior?
    • Is it better to have this be enabled or disabled by default?

@ghost
Copy link
Author

ghost commented May 5, 2017

i would argue it's better enabled by default, and that the code probably already knows/fetches mentions, as it beeps when you have the setting turned on, and are in another screen. "difference between total mentions and mentions that aren't included in the column" is a good question

@joyeusenoelle
Copy link
Contributor

I agree that enabled by default is probably the better option, I've just seen some people note that they appreciate that Mastodon doesn't tell them how many new mentions they have.

A thought that occurred to me today: do we need to show how many new notifications there are? Or just have a badge for when there are new notifications? Like:

Notifications (new!)

vs.

Notifications (42)

@beatrix-bitrot
Copy link
Contributor

i think having the number is nice, but if having it makes it significantly more complicated or causes display issues then i'm not sure it's worthwhile

@ghost
Copy link
Author

ghost commented May 6, 2017

what bea said. honestly i'd be happy/it might be prettiest if it just changed the color of the bell. probably best for all platforms overall, too.

abcang added a commit to pixiv/mastodon that referenced this issue Nov 15, 2017
@Cassolotl
Copy link

honestly i'd be happy/it might be prettiest if it just changed the color of the bell. probably best for all platforms overall, too.

This is now the case - maybe this issue could be closed?

@hidrarga
Copy link

This is now the case - maybe this issue could be closed?

Uh? When I receive a notification, the color of the bell doesn't change 😕

I'd be really interested in this feature, as I recently noticed that I could hide the notification column (on desktop view). What would be great now is to see that there are new notifications on the taskbar (the top menu). I know that the number of unread notifications appears on the "start panel", but then I must check that regularly... 😞

@Cassolotl
Copy link

screen shot 2018-03-29 at 23 54 59
screen shot 2018-03-29 at 23 55 30

But you're right - it only happens when you're scrolled down a bit and you can't see the most recent notification. I think I misunderstood you the first time I read this issue! Sorry about that. 😳

The option to be at the top of the notifications column and not autoscroll when new notifications come in would be nice. And then the bell would turn blue and you'd have to scroll up to read them.

@hidrarga
Copy link

Ohh I see what you meant ! But indeed that's not helping me, because I'm hiding this column :)

image

Here is a picture to help understanding what I mean when I say:

I know that the number of unread notifications appears on the "start panel"

I'd like to have the same feature, but on the top menu (desktop view):
image

Something like this would be nice as well:
image

@Cassolotl
Copy link

Ohhhhh that's nice! Now that we have the ability to unpin the Notifications column, little changes like this would make things a lot easier. Thank you for the mock-ups, they help a lot!

@Gargron Gargron closed this as completed Jun 28, 2018
@hidrarga
Copy link

@Gargron why did you close this issue ?!! Does that mean that you don't want to implement the feature I proposed ? or did you already implement it ?

Or did you just close this issue without any reason ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui Front-end, design
Projects
None yet
Development

No branches or pull requests

6 participants