Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Ubuntu for docker #10100

Merged
merged 1 commit into from Feb 24, 2019

Conversation

@Sir-Boops
Copy link
Contributor

commented Feb 23, 2019

  • Based on my image Here
  • 200~ish MB smaller then the current build ( When built right )
  • Build with jemalloc for slightly less ram usage
  • /Should/ be an exact drop in replacement ( I've been told by other that switched to using this image that's a complete drop in replacement and I don't see any reason it wouldn't be but another confirmation would be nice 馃槃 )
  • Only real downfall of this image is it has to be built using --squash ( docker beta feature ) or the image size will be huge from all the individual RUNs
Dockerfile Outdated
RUN chown -R mastodon:mastodon /mastodon

VOLUME /mastodon/public/system
FROM sirboops/nodejs:8.15.0 as node

This comment has been minimized.

Copy link
@Gargron

Gargron Feb 23, 2019

Member

Why sirboops namespace instead of official images?

This comment has been minimized.

Copy link
@Sir-Boops

Sir-Boops Feb 23, 2019

Author Contributor

Just so everything is built using the same libs

Official images afaik use alpine/Deb not Ubuntu

This comment has been minimized.

Copy link
@Sir-Boops

Sir-Boops Feb 23, 2019

Author Contributor

If you want everything built here I can switch it over to this

Just means alot longer build times

This comment has been minimized.

Copy link
@Gargron

Gargron Feb 23, 2019

Member

In for a penny, in for a pound. Let's switch to that. Just to have more confidence over long-term availability of these images.

@Sir-Boops

This comment has been minimized.

Copy link
Contributor Author

commented Feb 24, 2019

Updated to build everything locally

I haven't tested this exact build on a live server yet but everything built and assets compiled just fine locally 馃憤

Dockerfile Outdated Show resolved Hide resolved
@Gargron Gargron merged commit 1dbf993 into tootsuite:master Feb 24, 2019
11 checks passed
11 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details
@Shleeble

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2019

Thanks for the work @Sir-Boops. I agree with the local building method over prebaked images :)

eai04191 added a commit to stellarianetwork/mastodon that referenced this pull request Mar 7, 2019
hiyuki2578 added a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.