Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UI for creating polls #10184

Merged
merged 5 commits into from Mar 6, 2019

Conversation

@Gargron
Copy link
Member

commented Mar 5, 2019

grafik

@Gargron Gargron force-pushed the feature-poll-create-ui branch from bf6af63 to d948f04 Mar 6, 2019

@Gargron Gargron marked this pull request as ready for review Mar 6, 2019

@mayaeh

This comment has been minimized.

Copy link
Collaborator

commented Mar 6, 2019

Is there a possibility that it will fail if it is five minutes?
422 error returned.
2019-03-06 12 03 28

@Gargron

This comment has been minimized.

Copy link
Member Author

commented Mar 6, 2019

@mayaeh Fixed by #10186

@mayaeh

This comment has been minimized.

Copy link
Collaborator

commented Mar 6, 2019

Thank you.
Other action seems to be no problem in the range I tried.
There seems to be no error.

@mayaeh
mayaeh approved these changes Mar 6, 2019

@Gargron Gargron merged commit d97cbb0 into master Mar 6, 2019

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details

@Gargron Gargron deleted the feature-poll-create-ui branch Mar 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.