Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom emojis in poll options #10322

Merged
merged 4 commits into from Mar 20, 2019

Conversation

@ThibG
Copy link
Collaborator

commented Mar 19, 2019

I decided to list the used custom emoji in the REST serialization, but it's definitely not the most efficient way to do it. It was the easiest way with the current architecture though.
I can look into changing that if needed.

@ThibG ThibG force-pushed the ThibG:features/poll-options-emoji branch 2 times, most recently from 58c8c3c to a46fd72 Mar 19, 2019
@ThibG ThibG force-pushed the ThibG:features/poll-options-emoji branch from a46fd72 to 87bb3c7 Mar 19, 2019
@ThibG ThibG marked this pull request as ready for review Mar 19, 2019
@ThibG ThibG requested a review from Gargron Mar 19, 2019
@Gargron Gargron merged commit 80f0910 into tootsuite:master Mar 20, 2019
11 checks passed
11 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details
hiyuki2578 added a commit to ProjectMyosotis/mastodon that referenced this pull request Oct 2, 2019
* Backend changes for custom emoji support in poll options

* Serialize poll emojis in REST API

* Render custom emojis in poll options

* Render custom emoji in poll options on public pages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.