significant improvement in microformats markup #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 6, 2017 10:59
This is a huge improvement and I believe will close mastodon#965. Had these microformats reviewed by others in the community to help ensure they are at least correct, if not complete. I did not want to change the structure of the page, and so there it does not fully mark up the entire ancestry chain, or reply chain, only the direct decendants and direct ancestors are correctly associated, but this is likely fine as the most important bit is to have access to the urls for those toots which are now correctly fetchable.
|
@dissolve Have you seen the CodeClimate failures? https://codeclimate.com/github/tootsuite/mastodon/pull/1063 (Not a maintainer here, just someone who likes the PR. 😉) |
added 8 commits
April 9, 2017 00:18
|
keeping this PR up to date with master, its a bit of a nuisance to keep updating it. Any idea what is needed to proceed here? |
|
I'm reviewing this right now. |
Gargron
requested changes
Apr 12, 2017
|
|
||
| .status__content.e-content.p-name.emojify< | ||
| .status__content.p-name.emojify |
There was a problem hiding this comment.
The line is missing < at the end. That removes extra whitespace from the output HTML, which does get picked up visually because we want to support ASCII art in toot text
Gargron
approved these changes
Apr 12, 2017
thurloat
pushed a commit
to Moosetodon/mastodon
that referenced
this pull request
Apr 13, 2017
* significant improvement in microformats markup This is a huge improvement and I believe will close mastodon#965. Had these microformats reviewed by others in the community to help ensure they are at least correct, if not complete. I did not want to change the structure of the page, and so there it does not fully mark up the entire ancestry chain, or reply chain, only the direct decendants and direct ancestors are correctly associated, but this is likely fine as the most important bit is to have access to the urls for those toots which are now correctly fetchable. * improve code climate * trying to pass code climate tests * code climate * fix p-summary for content warning posts * fix error introduced when merging via github
Nyoho
referenced
this pull request
in Nyoho/mathtodon
Apr 25, 2017
* significant improvement in microformats markup This is a huge improvement and I believe will close #965. Had these microformats reviewed by others in the community to help ensure they are at least correct, if not complete. I did not want to change the structure of the page, and so there it does not fully mark up the entire ancestry chain, or reply chain, only the direct decendants and direct ancestors are correctly associated, but this is likely fine as the most important bit is to have access to the urls for those toots which are now correctly fetchable. * improve code climate * trying to pass code climate tests * code climate * fix p-summary for content warning posts * fix error introduced when merging via github
Nyoho
referenced
this pull request
in Nyoho/mathtodon
Apr 25, 2017
abcang
added a commit
to pixiv/mastodon
that referenced
this pull request
May 22, 2018
…eports Show count of remaining reports
2 tasks
This was referenced Dec 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a huge improvement and I believe will close #965.
Had these microformats reviewed by others in the community to help
ensure they are at least correct, if not complete.
I did not want to change the structure of the page, and so there it does
not fully mark up the entire ancestry chain, or reply chain, only the
direct decendants and direct ancestors are correctly associated, but
this is likely fine as the most important bit is to have access to the
urls for those toots which are now correctly fetchable.