Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting for whether to crop images in unexpanded toots #12126

Merged
merged 1 commit into from
Oct 24, 2019

Conversation

duxovni
Copy link
Contributor

@duxovni duxovni commented Oct 9, 2019

Fixes #9916 and #9582. Users can now select in the "Appearance" preferences menu whether they want to keep the old cropping behavior (the default) or show all images uncropped.

@Gargron Gargron merged commit 48f75b8 into mastodon:master Oct 24, 2019
@ghost
Copy link

ghost commented Oct 31, 2019

Deployed this to my instance, I notice it only works on posts with a single image. Is that intended? Posts with two or more images are still cropped.

@duxovni
Copy link
Contributor Author

duxovni commented Oct 31, 2019

Yes, it's deliberate that this only applies to posts with a single image; it's less clear what the correct behavior should be for posts with multiple images. I guess we could display them all uncropped in a single column?

@ghost
Copy link

ghost commented Oct 31, 2019

Ah okay, well the description in preferences ("Crop images in non-expanded toots to 16x9") implies that it will apply to all images in a post. I know if I told my users about this feature they would assume it was buggy.

I think there should be an option for both behaviours. Uncropped in a single column wouldn't look great, but some users / instances want that.

@marians
Copy link

marians commented May 26, 2021

Better late then never: I just came across this setting in Mastodon and find that it improves my experience significantly. Thanks for this contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Thumbnail strategy to show whole image
3 participants