Change media modals look in web UI #15217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Gargron
commented
Nov 24, 2020
•
Gargron
commented
- Change overlay background to match color of viewed image
- Add interactive reply/boost/favourite buttons to footer of modal
- Change ugly "View context" link to button among the action bar
Gargron
force-pushed
the
feature-media-modal-background
branch
from
547aa56
to
97c3803
Compare
|
There's one issue that is not blocking but would be nice to solve at some point. ModalRoot restores focus on the element that had focus when the modal was opened after the modal is closed. When clicking reply, the focus should go to the textarea, but I believe the aforementioned behaviour restores the focus to the clicked media gallery item instead. |
|
pagination dot is useful for "how many pictures on this post". Please not remove that |
|
Hm, thanks for the feedback. The problem is that a line of dots and a line of buttons don't look good next to each other. It needs some kind of new design concept to look passable. |
ykzts
approved these changes
Nov 25, 2020
- Change overlay background to match color of viewed image - Add interactive reply/boost/favourite buttons to footer of modal - Change ugly "View context" link to button among the action bar
Gargron
force-pushed
the
feature-media-modal-background
branch
from
97c3803
to
d3414b2
Compare
|
Dots restored, more subtle |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.