Fix mentions not being deleted efficiently #15416
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To further validate the speed gains from our recent optimizations, I tried running
time ./bin/tootctl domains purge mastodon.social -c 1 --verbose
with the old and new code.The old code raised:
while I had to stop the new one because it was still stuck at the third account after more than 40 minutes.
It turns out, as a regression from the recent optimizations, mentions were left untouched until
account.destroy
, which would then delete them individually, and executing queries to find and delete associated notifications, resulting in a massive slowdown.With this change, running
tootctl domains purge
raises: