Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to format links to twitter.com accounts #7016

Conversation

ThisIsMissEm
Copy link
Contributor

See the discussion on #3888 and #1849 — this attempts to clean up the stream UI because a LOT of people do use the crossposter which makes the stream presently almost unreadable when multiple accounts are mentioned.

@Gargron
Copy link
Member

Gargron commented Apr 2, 2018

I agree that it's a real problem and this might be a practical solution. But I can't help but feel that we're giving up something with this move. That goddamn crossposter is a curse.

@ThisIsMissEm
Copy link
Contributor Author

Yeah, crossposting is problematic, but that's currently how people are using the service, so let's pave the cowpath.

@@ -208,6 +209,10 @@ def link_to_hashtag(entity)
hashtag_html(entity[:hashtag])
end

def link_to_twitter(username)
"<span class=\"h-card\"><a href=\"https://twitter.com/#{username}\" target=\"blank\" rel=\"noopener noreferrer\" class=\"u-url mention\"><i class=\"fa fa-twitter\"></i>&nbsp;@<span>#{username}</span></a></span>"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should not insert font-awesome into the HTML that will be used in other servers and native apps (also, there is a CSS class whitelist that will strip this out on other Mastodon servers)

I suggest leaving it as a link, and inserting the icon in the JavaScript, if at all

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, that's a fair compromise. I'll update to just make it a @@twitter.com link

@Gargron
Copy link
Member

Gargron commented Apr 3, 2018

I'm having second thoughts about this. What kind of message does this send? That it's okay to give special treatment to Twitter? That we're never getting rid of it? It seems antitethical to our ideals.

A lot of new people are using these Twitter to Mastodon cross-posters. But do we really want to encourage that? What it enables is "set and forget", where people set the cross-posting up and never visit Mastodon again. They won't respond to toots then. So it becomes fake activity, and waste of disk space and processing power, and spam on the public timelines.

Tumblr doesn't allow cross-posting from Twitter, only to, and the same was true for Postereus and other richer platforms. Cross-posting is marketing, and I now realize more than ever that Twitter to Mastodon cross-posting is hurting Mastodon.

@ThisIsMissEm
Copy link
Contributor Author

ThisIsMissEm commented Apr 3, 2018 via email

@Cassolotl
Copy link

Cassolotl commented Apr 3, 2018

I asked for this feature before any user-friendly crossposters existed, because sometimes I wanted to refer to someone on Twitter with @username@instance and having it actually link up made a lot of sense to me. Now that I use a crossposter, most of my original toots are crossposted tweets - but I am more active on Mastodon than on Twitter by a long way, and when you see me fly by in the public timelines I don't look like a crossposter (except for the occasional quote-tweet).

I understand that the introduction of usable crossposters changes the landscape quite a bit, and I'm wondering if perhaps this is something to be brought up with the crossposter developers. Perhaps some kind of... what is that thing called, a dead man's switch? If someone doesn't log into or post on Mastodon for x amount of time, the crossposter stops working. So I'll go and suggest this on Mastodon and see what happens.

@ThisIsMissEm
Copy link
Contributor Author

@Gargron So, the consensus was to close this? I had seen cases where the @mistressemelia part of @mistressemelia@twitter.com was linked. I think this is a bug in Amaroq.

@Gargron
Copy link
Member

Gargron commented Apr 22, 2018

Yes, that's a bug in Amaroq, and I believe the consensus is that this should be closed.

@Gargron Gargron closed this Apr 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants