Highlight active tab in action bar #8673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rhoio
commented
Sep 10, 2018
rhoio
commented
|
What about putting it below, to be more consistent with the public view? |
|
Didn't know that there existed bars in the public view, so I put it where they looked best for me. Changed to border-bottom and same pixel width for consistency. |
ClearlyClaire
approved these changes
Sep 12, 2018
kyori19
pushed a commit
to kyori19/mastodon
that referenced
this pull request
Sep 20, 2018
* NavLinks with activeclass instead of Link in actionbar to highlight active tab * highlight border-bottom in action bar consistent to public view
koppepan1204
pushed a commit
to koppepan1204/mastodon
that referenced
this pull request
Oct 10, 2018
* NavLinks with activeclass instead of Link in actionbar to highlight active tab * highlight border-bottom in action bar consistent to public view
koppepan1204
pushed a commit
to koppepan1204/mastodon
that referenced
this pull request
Oct 12, 2018
* NavLinks with activeclass instead of Link in actionbar to highlight active tab * highlight border-bottom in action bar consistent to public view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.