Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight active tab in action bar #8673

Merged
merged 2 commits into from Sep 12, 2018

Conversation

@rhoio
Copy link
Contributor

commented Sep 10, 2018

bildschirmfoto 2018-09-10 um 23 48 05

@ThibG

This comment has been minimized.

Copy link
Collaborator

commented Sep 11, 2018

What about putting it below, to be more consistent with the public view?

@rhoio

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2018

Didn't know that there existed bars in the public view, so I put it where they looked best for me.

Changed to border-bottom and same pixel width for consistency.

@ThibG
ThibG approved these changes Sep 12, 2018

@Gargron Gargron merged commit 7b7c260 into tootsuite:master Sep 12, 2018

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details

@rhoio rhoio deleted the rhoio:wip/actionbar branch Sep 13, 2018

kyori19 added a commit to kyori19/mastodon that referenced this pull request Sep 20, 2018
Highlight active tab in action bar (tootsuite#8673)
* NavLinks with activeclass instead of Link in actionbar to highlight active tab

* highlight border-bottom in action bar consistent to public view
koppepan1204 pushed a commit to koppepan1204/mastodon that referenced this pull request Oct 10, 2018
Highlight active tab in action bar (tootsuite#8673)
* NavLinks with activeclass instead of Link in actionbar to highlight active tab

* highlight border-bottom in action bar consistent to public view
koppepan1204 pushed a commit to koppepan1204/mastodon that referenced this pull request Oct 12, 2018
Highlight active tab in action bar (tootsuite#8673)
* NavLinks with activeclass instead of Link in actionbar to highlight active tab

* highlight border-bottom in action bar consistent to public view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.