Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only focus first element of dropdown menus if using keyboard #8679

Merged
merged 2 commits into from Sep 13, 2018

Conversation

@ThibG
Copy link
Collaborator

commented Sep 11, 2018

Partially fixes #7641 (the issue with the privacy dropdown is slightly different but similar, and unfixed by this change)

@ThibG ThibG force-pushed the ThibG:fixes/dropdown-focus branch from ef6caaa to ba6c85c Sep 11, 2018

@ThibG ThibG requested a review from Gargron Sep 13, 2018

@Gargron Gargron merged commit f8160b6 into tootsuite:master Sep 13, 2018

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details
kyori19 added a commit to kyori19/mastodon that referenced this pull request Sep 20, 2018
Only focus first element of dropdown menus if using keyboard (tootsui…
…te#8679)

* Only focus first item of dropdown if it was opened via keyboard

* Improve keyboard VS mouse navigation of dropdown menus
koppepan1204 pushed a commit to koppepan1204/mastodon that referenced this pull request Oct 10, 2018
Only focus first element of dropdown menus if using keyboard (tootsui…
…te#8679)

* Only focus first item of dropdown if it was opened via keyboard

* Improve keyboard VS mouse navigation of dropdown menus
koppepan1204 pushed a commit to koppepan1204/mastodon that referenced this pull request Oct 12, 2018
Only focus first element of dropdown menus if using keyboard (tootsui…
…te#8679)

* Only focus first item of dropdown if it was opened via keyboard

* Improve keyboard VS mouse navigation of dropdown menus

@ThibG ThibG deleted the ThibG:fixes/dropdown-focus branch Mar 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.