Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow inbox owner to view implicitly targeted ActivityPub payload #9093

Merged
merged 1 commit into from Oct 25, 2018

Conversation

@Gargron
Copy link
Member

commented Oct 25, 2018

Fix #9091

Please review thoroughly... Does this logic make sense?

@ThibG
ThibG approved these changes Oct 25, 2018
Copy link
Collaborator

left a comment

Still not 100% sure about tying audience with mentions (silent or not), but this seems consistent with that.

It could be extended to other activities (e.g., Like), but we don't have the underlying mechanisms for that and I'm not sure it's worth it.

@Gargron Gargron merged commit d4cf963 into master Oct 25, 2018
11 checks passed
11 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details
@ykzts ykzts deleted the fix-9091 branch Oct 25, 2018
cyber-gene added a commit to ikebuku-ro/mastodon that referenced this pull request Oct 26, 2018
* 'master' of github.com:tootsuite/mastodon:
  Fix missing `mention` argument when processing incoming Create activities (tootsuite#9114)
  Skip link-back check if body is nil (tootsuite#9107)
  Remove character counter from edit profile (tootsuite#9100)
  Fix direct messages column not loading more items on scroll (tootsuite#9102)
  Fix conversations not being marked read on click (tootsuite#9103)
  Do not fetch preview card for mentioned users (tootsuite#6934)
  Allow inbox owner to view implicitly targeted ActivityPub payload (tootsuite#9093)
  cli: set exit_on_failure for all CLI classes (tootsuite#9094)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.