Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow inbox owner to view implicitly targeted ActivityPub payload #9093

Merged
merged 1 commit into from
Oct 25, 2018
Merged

Allow inbox owner to view implicitly targeted ActivityPub payload #9093

merged 1 commit into from
Oct 25, 2018

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented Oct 25, 2018

Fix #9091

Please review thoroughly... Does this logic make sense?

ClearlyClaire
ClearlyClaire approved these changes Oct 25, 2018
View reviewed changes
Copy link
Contributor

@ClearlyClaire ClearlyClaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not 100% sure about tying audience with mentions (silent or not), but this seems consistent with that.

It could be extended to other activities (e.g., Like), but we don't have the underlying mechanisms for that and I'm not sure it's worth it.

@Gargron Gargron merged commit d4cf963 into master Oct 25, 2018
@ykzts ykzts deleted the fix-9091 branch October 25, 2018 16:24
@mayaeh mayaeh mentioned this pull request Oct 26, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClearlyClaire ClearlyClaire ClearlyClaire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gargron @ClearlyClaire