Add setting to not aggregate reblogs #9248
Conversation
ClearlyClaire
force-pushed
the
features/opt-out-reblog-aggregation
branch
from
2be5f2b
to
340075e
Compare
| timeline_key = key(timeline_type, account_id) | ||
| reblog_key = key(timeline_type, account_id, 'reblogs') | ||
|
|
||
| if status.reblog? | ||
| if status.reblog? && (aggregate_reblogs.nil? || aggregate_reblogs) |
There was a problem hiding this comment.
This is a bit awkward, but basically none of the tests pass an actual local account (with an associated User) to those functions, so…
|
@Gargron any opinion on this? |
|
I am looking forward to merge! |
|
FYI: I'm using this PR on top of |
ClearlyClaire
force-pushed
the
features/opt-out-reblog-aggregation
branch
from
340075e
to
9c682f9
Compare
|
I added a hint because the description wasn't sufficiently clear: |
|
I often see the actions which are boost and mention. But boosted toot is not visible in my home timeline and only mentioning is visible. Otherwise, behavior remains as it is unless actively opt-outed, I like it. |
|
I think this is useful. In Japanese, especially in my visible range, I often see that they boosting post and then post impressions ( eg: I like this). This PR can omit this procedure. However, there are times when I do not want to see the same post many times. Also, it may be better to show that this setting does not affect posts received before changing this setting. Also, since the space between the hint and the next setting item is too narrow, I think that adjustment is necessary. |
ClearlyClaire
force-pushed
the
features/opt-out-reblog-aggregation
branch
from
24a66d5
to
09ab9d1
Compare
|
Updated the spacing and hint text
|
ClearlyClaire
force-pushed
the
features/opt-out-reblog-aggregation
branch
from
09ab9d1
to
3ac4f12
Compare
|
thank you! thank you for merging!! |
* Add setting to not aggregate reblogs Fixes mastodon#9222 * Handle cases where user is nil in add_to_home and add_to_list * Add hint for setting_aggregate_reblogs option * Reword setting_aggregate_reblogs label
Fixes #9222