New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to not aggregate reblogs #9248

Merged
merged 4 commits into from Dec 9, 2018

Conversation

Projects
None yet
5 participants
@ThibG
Copy link
Collaborator

ThibG commented Nov 9, 2018

Fixes #9222

@ThibG ThibG force-pushed the ThibG:features/opt-out-reblog-aggregation branch from 2be5f2b to 340075e Nov 9, 2018

timeline_key = key(timeline_type, account_id)
reblog_key = key(timeline_type, account_id, 'reblogs')

if status.reblog?
if status.reblog? && (aggregate_reblogs.nil? || aggregate_reblogs)

This comment has been minimized.

@ThibG

ThibG Nov 9, 2018

Author Collaborator

This is a bit awkward, but basically none of the tests pass an actual local account (with an associated User) to those functions, so…

@kit-ty-kate

This comment has been minimized.

Copy link

kit-ty-kate commented Nov 20, 2018

@Gargron any opinion on this?

@kedamaDQ

This comment has been minimized.

Copy link
Contributor

kedamaDQ commented Nov 25, 2018

I am looking forward to merge!

@kit-ty-kate

This comment has been minimized.

Copy link

kit-ty-kate commented Nov 27, 2018

FYI: I'm using this PR on top of 2.6.2 on my instance lesbiab.space and it works perfectly so far

@ThibG ThibG force-pushed the ThibG:features/opt-out-reblog-aggregation branch from 340075e to 9c682f9 Nov 27, 2018

@ThibG

This comment has been minimized.

Copy link
Collaborator Author

ThibG commented Nov 27, 2018

I added a hint because the description wasn't sufficiently clear:
screenshot_2018-11-27 preferences - mastodon instance perso de thibg

@kedamaDQ

This comment has been minimized.

Copy link
Contributor

kedamaDQ commented Dec 4, 2018

I often see the actions which are boost and mention. But boosted toot is not visible in my home timeline and only mentioning is visible.
I think to this is a very good function if frequently need to open the account timeline for check to "what is mentioned?".

Otherwise, behavior remains as it is unless actively opt-outed, I like it.

@mayaeh

This comment has been minimized.

Copy link
Collaborator

mayaeh commented Dec 5, 2018

I think this is useful.

In Japanese, especially in my visible range, I often see that they boosting post and then post impressions ( eg: I like this).
Then I will search for what he is talking about.

This PR can omit this procedure.

However, there are times when I do not want to see the same post many times.

Also, it may be better to show that this setting does not affect posts received before changing this setting.

Also, since the space between the hint and the next setting item is too narrow, I think that adjustment is necessary.
2018-12-05 14 54 59

@ThibG ThibG force-pushed the ThibG:features/opt-out-reblog-aggregation branch from 24a66d5 to 09ab9d1 Dec 5, 2018

@ThibG

This comment has been minimized.

Copy link
Collaborator Author

ThibG commented Dec 5, 2018

Updated the spacing and hint text

screenshot_2018-12-05 preferences - dev instance 1

@mayaeh

mayaeh approved these changes Dec 5, 2018

@ThibG ThibG force-pushed the ThibG:features/opt-out-reblog-aggregation branch from 09ab9d1 to 3ac4f12 Dec 6, 2018

@ThibG ThibG requested a review from Gargron Dec 6, 2018

@Gargron Gargron merged commit 81bda7d into tootsuite:master Dec 9, 2018

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details
@kedamaDQ

This comment has been minimized.

Copy link
Contributor

kedamaDQ commented Dec 9, 2018

thank you! thank you for merging!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment