New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the password form order #9267

Merged
merged 3 commits into from Nov 16, 2018

Conversation

Projects
None yet
3 participants
@mayaeh
Copy link
Collaborator

mayaeh commented Nov 12, 2018

Change the order of password change form on Preferences -> Security page.

I think that in the many password change form, the current password -> new password is in order.

With this change, I think that we can reduce the case of failing to change the password.

Also fixes the problem where translation of "New password" is not applied to label.

Before:
2018-11-12 21 39 33
After:
2018-11-12 20 54 38

@Gargron Gargron merged commit bdd3c8c into tootsuite:master Nov 16, 2018

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment