New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign admin accounts index #9340

Merged
merged 4 commits into from Nov 26, 2018

Conversation

Projects
None yet
4 participants
@Gargron
Copy link
Member

Gargron commented Nov 24, 2018

grafik

  • Make clear which accounts are deleted/suspended
  • Make clear which accounts are bots/staff (via badges)
  • Show when local account was last active and which IP it used
  • Strip whitespace before filtering
  • Default to not showing remote accounts
  • Default to not showing suspended accounts
  • Remove alphabetic ordering

@Gargron Gargron force-pushed the fix-admin-accounts-index branch 2 times, most recently from f393a04 to 929b4d1 Nov 24, 2018

Gargron added some commits Nov 24, 2018

Improve overview of accounts in admin UI
- Display suspended status, role, last activity and IP prominently
- Default to showing local accounts
- Default to not showing suspended accounts

@Gargron Gargron force-pushed the fix-admin-accounts-index branch from 929b4d1 to 67d467d Nov 25, 2018

Gargron added some commits Nov 25, 2018

@Gargron Gargron force-pushed the fix-admin-accounts-index branch from 262f7c9 to 5893bee Nov 25, 2018

@ThibG

This comment has been minimized.

Copy link
Collaborator

ThibG commented Nov 26, 2018

“Permissions” → “Roles”? “Permissions” kind of makes sense for Admin/Moderator/User, but not for bot

@Gargron

This comment has been minimized.

Copy link
Member Author

Gargron commented Nov 26, 2018

Yeah I can see the sense in that but would prefer not to update all the locales just for this.

@@ -63,7 +63,7 @@ function main() {
content.textContent = timeAgoString({
formatMessage: ({ id, defaultMessage }, values) => (new IntlMessageFormat(messages[id] || defaultMessage, locale)).format(values),
formatDate: (date, options) => (new Intl.DateTimeFormat(locale, options)).format(date),
}, datetime, now, datetime.getFullYear());
}, datetime, now, now.getFullYear());

This comment has been minimized.

@ThibG

ThibG Nov 26, 2018

Collaborator

…what?

This comment has been minimized.

@Gargron

Gargron Nov 26, 2018

Author Member

This is an unrelated fix. Public pages were displaying "Nov 28" even for dates 2 years back, unlike the web UI, which correctly displayed "Nov 28, 2016", because of this mistake

@ThibG
Copy link
Collaborator

ThibG left a comment

Overall, this seems like a good change. I would prefer the IP address tests being adapted rather than being deleted, though.
And there is this unrelated(?) JS change.

@ykzts

ykzts approved these changes Nov 26, 2018

@Gargron Gargron merged commit 73faada into master Nov 26, 2018

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details

@Gargron Gargron deleted the fix-admin-accounts-index branch Nov 26, 2018

@kit-ty-kate

This comment has been minimized.

Copy link

kit-ty-kate commented Nov 26, 2018

Remove alphabetic ordering

so the new default ordering is by "most recent" is that right?

@Gargron

This comment has been minimized.

Copy link
Member Author

Gargron commented Nov 26, 2018

Yes. I have not found any practical uses for alphabetic sorting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment