Add timeout to web push workers and stop retries when getting 4xx #9434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargron
force-pushed
the
fix-web-push-retry
branch
from
59f3062
to
4232587
Compare
|
1-3s is a bit on the low end, no? Why not something closer to the timeouts we use for basically everything else? |
|
Because webpush endpoints are either Mozilla or Google or Apple, or an app developer, i.e. I can expect it to not be under heavy load or to be able to handle big loads. 1 second for a request is really long! It's also not that critical. |
|
Hm, the instance issuing the notifications may itself have connectivity issues/be under load. Are those tasks really causing delays? If so, those changes are probably stopping legitimate notifications from being delivered, right? |
Add timeout of 10s to web push requests
Gargron
force-pushed
the
fix-web-push-retry
branch
from
edb9edd
to
25d8b9c
Compare
abcang
pushed a commit
to pixiv/mastodon
that referenced
this pull request
Oct 1, 2019
…stodon#9434) Add timeout of 10s to web push requests
hiyuki2578
pushed a commit
to ProjectMyosotis/mastodon
that referenced
this pull request
Oct 2, 2019
…stodon#9434) Add timeout of 10s to web push requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.