New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add account hashtags to ActivityPub actor JSON #9450

Merged
merged 1 commit into from Dec 13, 2018

Conversation

Projects
None yet
2 participants
@Gargron
Copy link
Member

Gargron commented Dec 7, 2018

Follow-up to #9427

@Gargron Gargron added the activitypub label Dec 7, 2018

@ThibG

ThibG approved these changes Dec 10, 2018

Copy link
Collaborator

ThibG left a comment

Not sure statuses hashtags and contents hashtags should be considered as two different things, but otherwise, LGTM

end

def href
explore_hashtag_url(object)

This comment has been minimized.

@ThibG

ThibG Dec 10, 2018

Collaborator

Not too sure statuses hashtags and account hashtags should be considered as two entirely different things?

@Gargron Gargron merged commit 6d2080a into master Dec 13, 2018

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.3 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details

@Gargron Gargron deleted the fix-activitypub-actor-tags branch Dec 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment