New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop gifv timeline preview explicitly when open the media gallery #9749

Merged
merged 1 commit into from Jan 7, 2019

Conversation

Projects
None yet
2 participants
@kedamaDQ
Copy link
Contributor

kedamaDQ commented Jan 7, 2019

Currently, timeline gifv preview does not stop when click and open the media gallery on Firefox.

firefox-min

However, on Safari, gifv preview stops when move the cursor after open the media gallery.

safari-min

On Chrome, gifv preview stops immediately when click.

chrome-min_1

I confirmed same behavior with Win7, Arch Linux and MacOS Mojave.

This PR makes to stop gifv preview on the timeline explicitly when open media gallery and unifies the behavior.

@Gargron

Gargron approved these changes Jan 7, 2019

@Gargron Gargron merged commit cf3c0fc into tootsuite:master Jan 7, 2019

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details

@kedamaDQ kedamaDQ deleted the kedamaDQ:stop-preview-explicitly branch Jan 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment