New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rescue SSL error in verify link service #9914

Merged
merged 1 commit into from Jan 24, 2019

Conversation

Projects
None yet
3 participants
@renatolond
Copy link
Collaborator

renatolond commented Jan 24, 2019

If the first link to be verified contains a rel=me link with a SSL error, the VerifyAccountLinksWorker will fail and not try the following links. This rescues the SSL error when fetching the link, avoiding this issue.

Rescue SSL error in verify link service
If the first link to be verified contains a rel=me link with a SSL
error, the VerifyAccountLinksWorker will fail and not try the following
links. This rescues the SSL error when fetching the link, avoiding this
issue.
@ykzts

ykzts approved these changes Jan 24, 2019

@Gargron Gargron merged commit e1ec3a9 into tootsuite:master Jan 24, 2019

10 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details

@renatolond renatolond deleted the masto-donte-com-br:bugfix/rescue_ssl_error_in_link_verification branch Jan 24, 2019

kedamaDQ added a commit to kedamaDQ/mastodon that referenced this pull request Jan 25, 2019

Rescue SSL error in verify link service (tootsuite#9914)
If the first link to be verified contains a rel=me link with a SSL
error, the VerifyAccountLinksWorker will fail and not try the following
links. This rescues the SSL error when fetching the link, avoiding this
issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment