New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename from instance to server #9938

Merged
merged 2 commits into from Feb 5, 2019

Conversation

Projects
None yet
2 participants
@mayaeh
Copy link
Collaborator

mayaeh commented Jan 28, 2019

Change the expression from "instance" to "server".
Please refer to #9937 .
What do you think?

There may still be leaks.
Should I also change the definition name such as %{instance}?

I have not tested this change yet.
I tried a simple operation test on my test server.
I executed "yarn manage:translations en", "i18n-tasks missing en" and "i18n-tasks unused en".

@mayaeh mayaeh changed the title [WIP] Rename from instance to server Rename from instance to server Jan 28, 2019

@Gargron

Gargron approved these changes Feb 5, 2019

@Gargron Gargron merged commit 46e806c into tootsuite:master Feb 5, 2019

11 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: check-i18n Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: install-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.4 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.5 Your tests passed on CircleCI!
Details
ci/circleci: test-ruby2.6 Your tests passed on CircleCI!
Details
ci/circleci: test-webui Your tests passed on CircleCI!
Details
codeclimate All good!
Details

@mayaeh mayaeh deleted the mayaeh:rename_instance-to-server branch Feb 5, 2019

@mayaeh

This comment has been minimized.

Copy link
Collaborator Author

mayaeh commented Feb 6, 2019

Thank you for merging the master branch.

lucida3rd added a commit to lucida3rd/mastodon that referenced this pull request Feb 6, 2019

#9938の対応
Rename from instance to server. (tootsuite#9938)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment