Skip to content

Commit d26a7f0

Browse files
authored
Merge pull request #1222 from topcoder-platform/dev
[PROD RELEASE] - Copilot Portal tweaks & tech dept clean up
2 parents a017b1d + 5ae7d43 commit d26a7f0

File tree

45 files changed

+14
-366
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

45 files changed

+14
-366
lines changed
-3 KB
Binary file not shown.
-23.2 KB
Binary file not shown.
-6.52 KB
Binary file not shown.
Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,9 @@
1-
import { ReactComponent as MFAImage } from './mfa.svg'
21
import { ReactComponent as AppleStore } from './apple-store.svg'
32
import credentialImage from './credential.png'
4-
import diceIdLogo from './dicelogo.png'
5-
import diceIdLogoBig from './dicelogobig.png'
6-
import diceIdLogoSmall from './dicelogosmall.png'
73
import googlePlay from './google-play.png'
84

95
export {
106
AppleStore,
117
credentialImage,
12-
diceIdLogo,
13-
diceIdLogoBig,
14-
diceIdLogoSmall,
158
googlePlay,
16-
MFAImage,
179
}

src/apps/accounts/src/lib/assets/security/mfa.svg

Lines changed: 0 additions & 4 deletions
This file was deleted.

src/apps/copilots/src/pages/copilot-opportunity-details/index.tsx

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -86,12 +86,8 @@ const CopilotOpportunityDetails: FC<{}> = () => {
8686
const [activeTab, setActiveTab]: [string, Dispatch<SetStateAction<string>>] = useState<string>(activeTabHash)
8787

8888
useEffect(() => {
89-
if (isAdminOrPM) {
90-
setActiveTab(activeTabHash)
91-
} else {
92-
setActiveTab('0')
93-
}
94-
}, [activeTabHash, isAdminOrPM])
89+
setActiveTab(activeTabHash)
90+
}, [activeTabHash])
9591

9692
const handleTabChange = useCallback((tabId: string): void => {
9793
setActiveTab(tabId)
@@ -286,7 +282,7 @@ const CopilotOpportunityDetails: FC<{}> = () => {
286282
<TabsNavbar
287283
defaultActive={activeTab}
288284
onChange={handleTabChange}
289-
tabs={getCopilotDetailsTabsConfig(isAdminOrPM, copilotApplications?.length || 0)}
285+
tabs={getCopilotDetailsTabsConfig(copilotApplications?.length || 0)}
290286
/>
291287
)
292288
}
@@ -297,7 +293,7 @@ const CopilotOpportunityDetails: FC<{}> = () => {
297293
opportunity={opportunity}
298294
members={members}
299295
onApplied={onApplied}
300-
isAdminOrPM
296+
isAdminOrPM={isAdminOrPM}
301297
/>
302298
)}
303299

src/apps/copilots/src/pages/copilot-opportunity-details/tabs/config/copilot-details-tabs-config.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ export enum CopilotDetailsTabViews {
55
applications = '1',
66
}
77

8-
export const getCopilotDetailsTabsConfig = (isAdminOrPM: boolean, count: number): TabsNavItem[] => (isAdminOrPM ? [
8+
export const getCopilotDetailsTabsConfig = (count: number): TabsNavItem[] => ([
99
{
1010
id: CopilotDetailsTabViews.details,
1111
title: 'Details',
@@ -18,11 +18,6 @@ export const getCopilotDetailsTabsConfig = (isAdminOrPM: boolean, count: number)
1818
id: CopilotDetailsTabViews.applications,
1919
title: 'Applications',
2020
},
21-
] : [
22-
{
23-
id: CopilotDetailsTabViews.details,
24-
title: 'Details',
25-
},
2621
])
2722

2823
export const CopilotDetailsTabsConfig: TabsNavItem[] = [

src/apps/learn/src/certification-details/enroll-cta-btn/EnrollCtaBtn.tsx

Lines changed: 2 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,10 @@
1-
import { Dispatch, FC, SetStateAction, useCallback, useContext, useState } from 'react'
1+
import { FC, useCallback, useContext } from 'react'
22
import { NavigateFunction, useNavigate } from 'react-router-dom'
33

44
import { Button } from '~/libs/ui'
55
import { profileContext, ProfileContextData } from '~/libs/core'
66

77
import { getAuthenticateAndEnrollRoute, getTCACertificationEnrollPath } from '../../learn.routes'
8-
import { LearnConfig } from '../../config'
9-
import { DiceModal } from '../../course-details/course-curriculum/dice-modal'
108

119
interface EnrollCtaBtnProps {
1210
certification: string
@@ -15,15 +13,9 @@ interface EnrollCtaBtnProps {
1513
const EnrollCtaBtn: FC<EnrollCtaBtnProps> = (props: EnrollCtaBtnProps) => {
1614
const navigate: NavigateFunction = useNavigate()
1715
const { initialized: profileReady, profile }: ProfileContextData = useContext(profileContext)
18-
const [isDiceModalOpen, setIsDiceModalOpen]: [boolean, Dispatch<SetStateAction<boolean>>]
19-
= useState<boolean>(false)
2016

2117
const isLoggedIn: boolean = profileReady && !!profile
2218

23-
function onDiceModalClose(): void {
24-
setIsDiceModalOpen(false)
25-
}
26-
2719
/**
2820
* Handle user click on start course/resume/login button
2921
*/
@@ -37,15 +29,8 @@ const EnrollCtaBtn: FC<EnrollCtaBtnProps> = (props: EnrollCtaBtnProps) => {
3729
return
3830
}
3931

40-
// if the user is wipro and s/he hasn't set up DICE,
41-
// let the user know
42-
if (LearnConfig.REQUIRE_DICE_ID && profile?.isWipro && !profile.diceEnabled) {
43-
setIsDiceModalOpen(true)
44-
return
45-
}
46-
4732
navigate(getTCACertificationEnrollPath(props.certification))
48-
}, [isLoggedIn, profile?.isWipro, profile?.diceEnabled, props, navigate])
33+
}, [isLoggedIn, props, navigate])
4934

5035
return (
5136
<>
@@ -55,11 +40,6 @@ const EnrollCtaBtn: FC<EnrollCtaBtnProps> = (props: EnrollCtaBtnProps) => {
5540
label={isLoggedIn ? 'Enroll Now' : 'Log in to enroll'}
5641
onClick={handleEnrollClick}
5742
/>
58-
59-
<DiceModal
60-
isOpen={isDiceModalOpen}
61-
onClose={onDiceModalClose}
62-
/>
6343
</>
6444
)
6545
}

src/apps/learn/src/config/learn-config.model.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,5 +7,4 @@ export interface LearnConfigModel {
77
value: string,
88
}
99
CLIENT: string
10-
REQUIRE_DICE_ID: boolean | undefined
1110
}

src/apps/learn/src/config/learn.default.config.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import { EnvironmentConfig } from '~/config'
2-
import { getReactEnv } from '~/config/environments/react-env'
32

43
import { LearnConfigModel } from './learn-config.model'
54

@@ -14,5 +13,4 @@ export const LearnConfigDefault: LearnConfigModel = {
1413
value: 'certificate-container',
1514
},
1615
CLIENT: 'https://fcc.topcoder-dev.com:4431',
17-
REQUIRE_DICE_ID: `${getReactEnv<string>('REQUIRE_DICE_ID', '')}` === 'true',
1816
}

0 commit comments

Comments
 (0)