Add views #8
Add views #8
Conversation
There was a problem hiding this comment.
Hi @topeogunleye 👋,
Good job so far!
Highlights
- Has correct logic for
indexandshowactions in Users Controllers ✔️ - Has correct logic for
indexandshowactions in Posts Controllers ✔️ - Set up View files for the
Usercontroller correctly ✔️ - Set up View files for the
Postcontroller correctly ✔️ - Has dedicated routes for each View file ✔️
However, there are some issues that you still need to work on to go to the next project but you are almost there!
Required Changes ♻️
I am making this comment here because I can not highlight the required piece of code in the files changed section
- Kindly delete the migrations files that were created when you attempted to use
DeviseandCanCanCangems for this milestone. The reason for this is I can't create a user successfully if they are not deleted and they are not required for this milestone. 👍
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
- You can also consider using partial for rendering common views in your User view files. Making use of partials is one of the Ruby on Rails best practices because it ensures that you do not repeat codes in the view files. You can read this documentation for a better understanding. Kindly consider this suggestion. 👍
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
@Gambit142, Thank you so much for your wonderful review 👍 |
There was a problem hiding this comment.
Hi 👋 @topeogunleye,
Great work on making the changes requested by a previous reviewer 👏
You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.
Highlights
You have done a great job working on the requested changes 👍
Required Changes ♻️
Check the comments under the review.
- Kindly commit the changes requested by the previous reviewer.
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
… Devise and CanCanCan
There was a problem hiding this comment.
Hi @topeogunleye,
Status: Approved ✔️
Your project is complete! There is nothing else to say other than... it's time to merge it 🚢
Congratulations! 🎉
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
You can also consider:
- Adding proper steps in the README file to run the project from clone to running the server. You have mentioned some of the steps but that doesn't help the recruiter, that's why always try to add all the steps with full clarity.
$ git clone https://github.com/topeogunleye/blog-app-rails.git
$ cd blog-app-rails
$ bundle
$ rails db:setup
$ rails s
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Thanks for your kind review. I will implement the optional changes immediately. |
Added Changes