Milestone 10: Authorization with Can Can Can

[topeogunleye]

Milestone 10: Authorization with Can Can Can

In this Pull Request, I:

• Installed CanCanCan in your project.
• Added a role column to the users table. Remember to use a migration for this.
• A user can delete a post if it is theirs or if they have an admin role (column role has value "admin"). Used CanCanCan for this authorization.
  • For that you need to implement the post deleting functionality. Add the "Delete" button to the view and make sure that only authorized users can see it.
• A user can delete a comment if it is theirs or if they have an admin role (column role has value "admin"). Use CanCanCan for this authorization.
  • For that you need to implement the comment deleting functionality. Added the "Delete" button to the view and make sure that only authorized users can see it.

[KDlamini]

Hi team @topeogunleye, @rolandfbk 🙋‍♀️,

Great work so far! 💯
You still need to work on some issues to improve your project according to the requirements. You are almost there! 💪🏾

Highlights 🌞

✔️ Cancancan gem is used
✔️ the Ability class is implemented
✔️ Good PR title and description
✔️ Correct use of Gitflow
✔️ Commit messages are meaningful
✔️ No linter errors

Required Changes ♻️

Kindly look through the comments below 👇 for required changes

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers 🥂 and Happy coding!!! 👯
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Remember to tag me @KDlamini in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

---

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

[KDlamini]

I am unable to sign up in order to log in and check if the authorization works properly.

• Kindly look into your registration so that we can be able to log in and test for authorization.

[topeogunleye]

I have fixed it. Please check again

[smunozmo]

Hi @topeogunleye, 👋

Highlights 👏

• Authorization features are working correctly, congrats! 😎
• Excellent job making the suggested changes, perfect! 🎉
• Well done using CanCanCan! ✅
• Great work using the right GitHub Flow.
• Your README looks professional, well done!
• Commits are descriptive, good work.
• Linters are working properly, great job!

Your project is complete! There is nothing else to say other than... it's time to merge it! 🚀
Very nice work, congratulations! 🎉

APPROVED! 💯 💯 💯

Cheers and Happy coding! 🤓

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

✅ Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

---

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.