Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/create data model #16

Open
wants to merge 21 commits into
base: dev
Choose a base branch
from
Open

Conversation

topeogunleye
Copy link
Owner

Blog app milestone 1: Data Models

In this pull request, I:

  • Created and ran the migration files
  • Added foreign key and indexes.

Copy link

@AnselemOdims AnselemOdims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @topeogunleye 🙋‍♀️,

Good job implementing all the project requirements for this milestone/project.

STATUS APPROVED ✔

Your project is complete! There is nothing else to say other than... it's time to merge it 🔗 🚢
Congratulations! 🎉

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers 🥂 and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Use the tag @AnselemOdims for a quicker reply

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants