Milestone 8: Intergration specs #8
Conversation
… intergrationSpecs
There was a problem hiding this comment.
Hi, @topeogunleye👋,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Status: Invalid Code Review Request
You have submitted a project, with failed linters. Kindly fix them and request another review.
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @brytebee in your question so I can receive the notification.
Use @brytebee on slack for faster responses.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
Invalid Code Review Request does not count into the code reviews limit.
There was a problem hiding this comment.
Hi @topeogunleye,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights
- Linters are green ✅.
- PR is very detailed✅.
- The Readme file is very good ✅.
- Commit are consistent ✅.
Required Changes ♻️
Check the comments under the review.
- Nice job on adding the test suits but the test is not passing due to the incorrect folder put in so, please relocate the files to the correct spec folder and remove the other and check before sending the PR for review
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
You can also consider:
- N/A
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
@dasileker, Please what's the correct folder to put my tests in |
|
Hello, like I said you have two folders, do this one is not the correct one, you can refer to this article how to set up rspec |
There was a problem hiding this comment.
Hi @topeogunleye 👋,
Great work on making the changes requested by a previous reviewer 👏
You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.
Highlights
- No linter errors 👍
- Good looking readme file 👍
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Kindly note that this is a paired programming project activity and as such contributions are expected from your partners, please take note as in the future your code review requests would be invalidated. note ✍️ if you have permission from the student success to work solo kindly attach it to your PR so the CR can see it 👍
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @Davidosky007 in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
spec/helpers/users_helper_spec.rb
Outdated
| require 'rails_helper' | ||
|
|
||
| # Specs in this file have access to a helper object that includes | ||
| # the UsersHelper. For example: | ||
| # | ||
| # describe UsersHelper do | ||
| # describe "string concat" do | ||
| # it "concats two strings with spaces" do | ||
| # expect(helper.concat_strings("this","that")).to eq("this that") | ||
| # end | ||
| # end | ||
| # end |
There was a problem hiding this comment.
- I get an error here when i run
rspeckindly fix this error HINT 💭 I tried commenting out lines 13 to 15 and got some test passing but 3tests were still failing below is the screenshot of the new error i got after modifying this file
new error
There was a problem hiding this comment.
@Davidosky007 This file is not a part pf the tests
There was a problem hiding this comment.
I know that but if any visitor of your repo decides to run your test they will definitely have that error
There was a problem hiding this comment.
Okay. Thank you for explaining @Davidosky007
There was a problem hiding this comment.
STATUS: APPROVED 🍾✔🎉
Hello @topeogunleye 👋
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Highlights
- You documented your work professionally.✔
- Your linters are passing all the checks
- You asked for the changes in a polite and friendly way.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
There was a problem hiding this comment.
Hi @topeogunleye ,
Your project is complete! There is nothing else to say other than... it's time to merge it
Congratulations! 🎉
sorry for the inconvenience experienced 💯
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
|
Hello.
I am pretty sure I selected approved on my dashboard
Le mer. 24 août 2022 à 11:12, Temitope Ogunleye ***@***.***>
a écrit :
… *STATUS: APPROVED 🍾✔🎉* Hello @topeogunleye
<https://github.com/topeogunleye> 👋 Your project is complete! There is
nothing else to say other than... it's time to merge it [image:
]
Congratulations! 🎉
Highlights
- You documented your work professionally.✔
- Your linters are passing all the checks
- You asked for the changes in a polite and friendly way.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something
is not 100% clear. Please, remember to tag me in your question so I can
receive the notification.
*As described in the Code reviews limits policy
<https://microverse.zendesk.com/hc/en-us/articles/1500004088561> you have a
limited number of reviews per project (check the exact number in your
Dashboard). If you think that the code review was not fair, you can request
a second opinion using this form <https://airtable.com/shrQAqnBwek5a0O0s>.*
@emmanuellekamwa <https://github.com/emmanuellekamwa>, Thanks for
approving. However on my dashboard, I currently have requested changes and
not submit button. I think you selected the request changes on your review
dashboard
—
Reply to this email directly, view it on GitHub
<#8 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOTSG73LV5ZNNEU6BBHP3DLV2XYPTANCNFSM57HYU6AA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Milestone 8: Integration Tests
The Linters pass locally, but fail on GitHub pls