Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add shopping list #30

Merged
merged 7 commits into from
Feb 11, 2023
Merged

Feature/add shopping list #30

merged 7 commits into from
Feb 11, 2023

Conversation

adel-gu
Copy link
Collaborator

@adel-gu adel-gu commented Feb 11, 2023

Changes Implemented in this PR

  • Show the list of food that is missing by comparing the food in the recipe with the food in the inventory.
  • Count the total food items and total price of the missing food.

@adel-gu adel-gu linked an issue Feb 11, 2023 that may be closed by this pull request
[3.0pts] Inventory shopping list: #12
Closed
@adel-gu adel-gu requested a review from dlwub February 11, 2023 08:41
dlwub
dlwub approved these changes Feb 11, 2023
View reviewed changes
Copy link
Collaborator

@dlwub dlwub left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @adel-gu:
A very good job in implementing the project's requirements. There is nothing else to say other than it is time to merge your PR 💯

  • No linter errors
  • A descriptive PR
  • Correct git flow

@adel-gu adel-gu merged commit c811e73 into dev Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlwub dlwub dlwub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[3.0pts] Inventory shopping list:
2 participants
@adel-gu @dlwub