HTTP StatusCode 500 when a player tries to apply for a clan he's already a member

[traysh]

Wrong HTTP status code but right response body

Request:

url: http://localhost:5050/clans/11111111111111111111111111111113/memberships/application
payload: {
  "level": "member",
  "user_id": "11111111111111111111111111111113",
  "message": "oi, deixa eu entrar?"
}

Response:

statusCode: 500
body: {
  "success": false,
  "reason": "Player 11111111111111111111111111111113 already has a valid membership in clan 11111111111111111111111111111113."
}

[cscatolini]

@traysh This is a know issue in Khan, we basically respond with 500 when anything goes wrong. I'll leave your issue here as a reminder to fix this, but I don't see this being fixed anytime soon.

[yuriabrito]

Returning 409 when player is already a member, and 400 when player doesn't exist (instead of 500)

#17