feat(brew): adds "greedy-latest" option to Brew #636

luciodaou · 2024-01-06T00:51:57Z

Standards checklist:

The PR title is descriptive.
I have read CONTRIBUTING.md
The code compiles (cargo build)
The code passes rustfmt (cargo fmt)
The code passes clippy (cargo clippy)
The code passes tests (cargo test)
Optional: I have tested the code myself

Adds a new boolean option greedy_latest in the config file for Brew/Homebrew, equivalent to the command line option --greedy-latest to brew upgrade, based on greedy_cask itself.

This is because greedy_cask invokes brew's --greddy, that updates "casks with auto_updates or version :latest". As I've been having some issues in apps with auto update, I decided to add this new option to allow for the git casks to be updated without touching the auto update ones.

Here is the result of the first test run:

Code test result

Output

topgrade/target/debug on  main [!] 
🍎 ❯ ./topgrade --only brew_cask brew_formula

── 21:19:04 - Topgrade 13.0.0 Breaking Changes ─────────────────────────────────
No Breaking changes

Confirmed? (y)es/(N)o
── 21:19:12 - Brew ─────────────────────────────────────────────────────────────
Updated 1 tap (homebrew/cask-fonts).
No changes to formulae or casks.

── 21:19:17 - Brew - Cask ──────────────────────────────────────────────────────
==> Casks with 'auto_updates true' will not be upgraded; pass `--greedy-auto-updates` to upgrade them.
==> Upgrading 5 outdated packages:
homebrew/cask-fonts/font-montserrat latest -> latest
homebrew/cask-fonts/font-red-hat-display latest -> latest
homebrew/cask-fonts/font-red-hat-mono latest -> latest
homebrew/cask-fonts/font-red-hat-text latest -> latest
homebrew/cask-fonts/font-source-code-pro latest -> latest
==> Upgrading font-montserrat
==> Cloning https://github.com/google/fonts.git
Updating /Users/lucio/Library/Caches/Homebrew/Cask/font-montserrat--git-sparse
From https://github.com/google/fonts
 b8198929..837b031e  main       -> origin/main
==> Checking out branch main
Already on 'main'
Your branch is behind 'origin/main' by 221 commits, and can be fast-forwarded.
(use "git pull" to update your local branch)
HEAD is now at 837b031e Merge pull request #7146 from google/lang-v0515
Warning: No checksum defined for cask 'font-montserrat', skipping verification.
==> Backing Font 'Montserrat-Italic[wght].ttf' up to '/opt/homebrew/Caskroom/font-montserrat/latest/ofl/montse
==> Removing Font '/Users/lucio/Library/Fonts/Montserrat-Italic[wght].ttf'
==> Backing Font 'Montserrat[wght].ttf' up to '/opt/homebrew/Caskroom/font-montserrat/latest/ofl/montserrat/Mo
==> Removing Font '/Users/lucio/Library/Fonts/Montserrat[wght].ttf'
==> Moving Font 'Montserrat-Italic[wght].ttf' to '/Users/lucio/Library/Fonts/Montserrat-Italic[wght].ttf'
==> Moving Font 'Montserrat[wght].ttf' to '/Users/lucio/Library/Fonts/Montserrat[wght].ttf'
==> Purging files for version latest of Cask font-montserrat
🍺  font-montserrat was successfully upgraded!
==> Upgrading font-red-hat-display
==> Cloning https://github.com/google/fonts.git
Updating /Users/lucio/Library/Caches/Homebrew/Cask/font-red-hat-display--git-sparse
From https://github.com/google/fonts
 b8198929..837b031e  main       -> origin/main
==> Checking out branch main
Already on 'main'
Your branch is behind 'origin/main' by 221 commits, and can be fast-forwarded.
(use "git pull" to update your local branch)
HEAD is now at 837b031e Merge pull request #7146 from google/lang-v0515
Warning: No checksum defined for cask 'font-red-hat-display', skipping verification.
==> Backing Font 'RedHatDisplay-Italic[wght].ttf' up to '/opt/homebrew/Caskroom/font-red-hat-display/latest/of
==> Removing Font '/Users/lucio/Library/Fonts/RedHatDisplay-Italic[wght].ttf'
==> Backing Font 'RedHatDisplay[wght].ttf' up to '/opt/homebrew/Caskroom/font-red-hat-display/latest/ofl/redha
==> Removing Font '/Users/lucio/Library/Fonts/RedHatDisplay[wght].ttf'
==> Moving Font 'RedHatDisplay-Italic[wght].ttf' to '/Users/lucio/Library/Fonts/RedHatDisplay-Italic[wght]
==> Moving Font 'RedHatDisplay[wght].ttf' to '/Users/lucio/Library/Fonts/RedHatDisplay[wght].ttf'
==> Purging files for version latest of Cask font-red-hat-display
🍺  font-red-hat-display was successfully upgraded!
==> Upgrading font-red-hat-mono
==> Cloning https://github.com/google/fonts.git
Updating /Users/lucio/Library/Caches/Homebrew/Cask/font-red-hat-mono--git-sparse
From https://github.com/google/fonts
 b8198929..837b031e  main       -> origin/main
==> Checking out branch main
Already on 'main'
Your branch is behind 'origin/main' by 221 commits, and can be fast-forwarded.
(use "git pull" to update your local branch)
HEAD is now at 837b031e Merge pull request #7146 from google/lang-v0515
Warning: No checksum defined for cask 'font-red-hat-mono', skipping verification.
==> Backing Font 'RedHatMono-Italic[wght].ttf' up to '/opt/homebrew/Caskroom/font-red-hat-mono/latest/ofl/redh
==> Removing Font '/Users/lucio/Library/Fonts/RedHatMono-Italic[wght].ttf'
==> Backing Font 'RedHatMono[wght].ttf' up to '/opt/homebrew/Caskroom/font-red-hat-mono/latest/ofl/redhatmono/
==> Removing Font '/Users/lucio/Library/Fonts/RedHatMono[wght].ttf'
==> Moving Font 'RedHatMono-Italic[wght].ttf' to '/Users/lucio/Library/Fonts/RedHatMono-Italic[wght].ttf'
==> Moving Font 'RedHatMono[wght].ttf' to '/Users/lucio/Library/Fonts/RedHatMono[wght].ttf'
==> Purging files for version latest of Cask font-red-hat-mono
🍺  font-red-hat-mono was successfully upgraded!
==> Upgrading font-red-hat-text
==> Cloning https://github.com/google/fonts.git
Updating /Users/lucio/Library/Caches/Homebrew/Cask/font-red-hat-text--git-sparse
From https://github.com/google/fonts
 b8198929..837b031e  main       -> origin/main
==> Checking out branch main
Already on 'main'
Your branch is behind 'origin/main' by 221 commits, and can be fast-forwarded.
(use "git pull" to update your local branch)
HEAD is now at 837b031e Merge pull request #7146 from google/lang-v0515
Warning: No checksum defined for cask 'font-red-hat-text', skipping verification.
==> Backing Font 'RedHatText-Italic[wght].ttf' up to '/opt/homebrew/Caskroom/font-red-hat-text/latest/ofl/redh
==> Removing Font '/Users/lucio/Library/Fonts/RedHatText-Italic[wght].ttf'
==> Backing Font 'RedHatText[wght].ttf' up to '/opt/homebrew/Caskroom/font-red-hat-text/latest/ofl/redhattext/
==> Removing Font '/Users/lucio/Library/Fonts/RedHatText[wght].ttf'
==> Moving Font 'RedHatText-Italic[wght].ttf' to '/Users/lucio/Library/Fonts/RedHatText-Italic[wght].ttf'
==> Moving Font 'RedHatText[wght].ttf' to '/Users/lucio/Library/Fonts/RedHatText[wght].ttf'
==> Purging files for version latest of Cask font-red-hat-text
🍺  font-red-hat-text was successfully upgraded!
==> Upgrading font-source-code-pro
==> Cloning https://github.com/google/fonts.git
Updating /Users/lucio/Library/Caches/Homebrew/Cask/font-source-code-pro--git-sparse
From https://github.com/google/fonts
 b8198929..837b031e  main       -> origin/main
==> Checking out branch main
Already on 'main'
Your branch is behind 'origin/main' by 221 commits, and can be fast-forwarded.
(use "git pull" to update your local branch)
HEAD is now at 837b031e Merge pull request #7146 from google/lang-v0515
Warning: No checksum defined for cask 'font-source-code-pro', skipping verification.
==> Backing Font 'SourceCodePro-Italic[wght].ttf' up to '/opt/homebrew/Caskroom/font-source-code-pro/latest/of
==> Removing Font '/Users/lucio/Library/Fonts/SourceCodePro-Italic[wght].ttf'
==> Backing Font 'SourceCodePro[wght].ttf' up to '/opt/homebrew/Caskroom/font-source-code-pro/latest/ofl/sourc
==> Removing Font '/Users/lucio/Library/Fonts/SourceCodePro[wght].ttf'
==> Moving Font 'SourceCodePro-Italic[wght].ttf' to '/Users/lucio/Library/Fonts/SourceCodePro-Italic[wght]
==> Moving Font 'SourceCodePro[wght].ttf' to '/Users/lucio/Library/Fonts/SourceCodePro[wght].ttf'
==> Purging files for version latest of Cask font-source-code-pro
🍺  font-source-code-pro was successfully upgraded!

── 21:19:31 - Summary ──────────────────────────────────────────────────────────
Brew (ARM): OK
Brew Cask (ARM): OK

SteveLauC

So IIUC, --greedy contains --greedy-latest, can they be used together? i.e.:

$ brew upgrade --greedy --greedy-latest

luciodaou · 2024-01-06T15:06:24Z

So IIUC, --greedy contains --greedy-latest, can they be used together? i.e.:
$ brew upgrade --greedy --greedy-latest

Good question. I just checked and yes, they can and brew doesn't complain about it:

It's not the most "elegant" way, as greedy_cask being enabled could omit greedy_latest. But, as shown above, it creates no conflicts with brew.

SteveLauC · 2024-01-07T02:11:23Z

Can I trouble you to add some documents on these 2 configuration entries in the config.example.toml file, what they are and what will happen if they are enabled. And, maybe we should document that greedy_cask would contain greedy_latest so that users won't need to set greedy_latest if greedy_cask is set.

luciodaou · 2024-01-07T17:04:24Z

Can I trouble you to add some documents on these 2 configuration entries in the config.example.toml file, what they are and what will happen if they are enabled. And, maybe we should document that greedy_cask would contain greedy_latest so that users won't need to set greedy_latest if greedy_cask is set.

Not a problem at all. I'll do it soon. 👍

SteveLauC · 2024-02-17T03:45:40Z

It has been a while, let's merge this PR:)

Lucio Daou added 2 commits January 5, 2024 20:38

feat(brew): adds "greedy-latest" option to Brew

4183d44

feat(brew): adds "greedy-latest" option to Brew

e62f723

SteveLauC reviewed Jan 6, 2024

View reviewed changes

SteveLauC mentioned this pull request Feb 6, 2024

feat: add fetch_head configuration option into brew #679

Merged

10 tasks

SteveLauC approved these changes Feb 17, 2024

View reviewed changes

SteveLauC merged commit 8991bc9 into topgrade-rs:main Feb 17, 2024
7 checks passed

BrewTestBot mentioned this pull request Jul 1, 2024

topgrade 15.0.0 Homebrew/homebrew-core#176036

Merged

Neved4 mentioned this pull request Sep 25, 2024

feat(brew): Add greedy_auto_updates option to Brew #914

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(brew): adds "greedy-latest" option to Brew #636

feat(brew): adds "greedy-latest" option to Brew #636

luciodaou commented Jan 6, 2024 •

edited

Loading

SteveLauC left a comment

luciodaou commented Jan 6, 2024

SteveLauC commented Jan 7, 2024

luciodaou commented Jan 7, 2024

SteveLauC commented Feb 17, 2024

feat(brew): adds "greedy-latest" option to Brew #636

feat(brew): adds "greedy-latest" option to Brew #636

Conversation

luciodaou commented Jan 6, 2024 • edited Loading

Standards checklist:

Output

SteveLauC left a comment

Choose a reason for hiding this comment

luciodaou commented Jan 6, 2024

SteveLauC commented Jan 7, 2024

luciodaou commented Jan 7, 2024

SteveLauC commented Feb 17, 2024

luciodaou commented Jan 6, 2024 •

edited

Loading