feat: certbot renew #665
Merged
feat: certbot renew #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveLauC
commented
Jan 26, 2024
| @@ -905,3 +908,16 @@ pub fn run_bob(ctx: &ExecutionContext) -> Result<()> { | |||
|
|
|||
| ctx.run_type().execute(bob).args(["update", "--all"]).status_checked() | |||
| } | |||
|
|
|||
| pub fn run_certbot(ctx: &ExecutionContext) -> Result<()> { | |||
There was a problem hiding this comment.
It simply executes sudo certbot renew:
$ ./target/debug/topgrade --only certbot
── 10:27:23 - Sudo ─────────────────────────────────────────────────────────────
── 10:27:23 - Certbot ──────────────────────────────────────────────────────────
certbot // fake output
── 10:27:23 - Summary ──────────────────────────────────────────────────────────
Certbot: OK$ ./target/debug/topgrade --only certbot --dry-run
── 10:27:41 - Sudo ─────────────────────────────────────────────────────────────
Dry running: /usr/bin/sudo -v
── 10:27:41 - Certbot ──────────────────────────────────────────────────────────
Dry running: /usr/bin/sudo /home/steve/.local/bin/certbot renew
── 10:27:41 - Summary ──────────────────────────────────────────────────────────
Certbot: OK
Right. Since |
|
I tested the branch looks good so far, now a test with a failing certbot: So, from my side the test was successful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standards checklist:
CONTRIBUTING.mdcargo build)cargo fmt)cargo clippy)cargo test)For new steps
Optional: Topgrade skips this step where needed
Optional: The
--dry-runoption works with this stepOptional: The
--yesoption works with this step if it is supported bythe underlying command
The
certbotcommand does not seem to support this feature, right @bw1faeh0?If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.