Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support wildcard in ignored_containers #666

Merged

Conversation

SteveLauC
Copy link
Member

Standards checklist:

  • The PR title is descriptive.
  • I have read CONTRIBUTING.md
  • The code compiles (cargo build)
  • The code passes rustfmt (cargo fmt)
  • The code passes clippy (cargo clippy)
  • The code passes tests (cargo test)
  • Optional: I have tested the code myself

For new steps

  • Optional: Topgrade skips this step where needed
  • Optional: The --dry-run option works with this step
  • Optional: The --yes option works with this step if it is supported by
    the underlying command

If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.

Closes #653

@SteveLauC
Copy link
Member Author

Hi @mortenlj, I cannot give you a pre-built binary unless you are a Linux user, in case of so, would you like to build Topgrade against my branch and give it a test?

@mortenlj
Copy link

I cloned your branch and built it. Seems to work wonders 👍

@SteveLauC SteveLauC merged commit 77ff6cb into topgrade-rs:main Jan 27, 2024
8 checks passed
@SteveLauC SteveLauC deleted the ignore_container_with_wildcard branch January 27, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support wildcards in ignored_containers
2 participants