Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: softwareupdate under dry run #668

Merged
merged 1 commit into from
Jan 27, 2024

Conversation

schrobingus
Copy link
Contributor

@schrobingus schrobingus commented Jan 27, 2024

Standards checklist:

  • I have read CONTRIBUTING.md
  • The PR title is descriptive.
  • The code compiles (cargo build)
  • The code passes rustfmt (cargo fmt)
  • The code passes clippy (cargo clippy)
  • The code passes tests (cargo test)
  • Optional: I have tested the code myself

This is just a simple fix on the macOS softwareupdate step, as the boolean should_ask wasn't conditional to dry runs prior.

@schrobingus schrobingus mentioned this pull request Jan 27, 2024
10 tasks
Copy link
Member

@SteveLauC SteveLauC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SteveLauC SteveLauC merged commit 30c5b31 into topgrade-rs:main Jan 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants