Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for Wolfi #672

Merged
merged 3 commits into from
Jan 29, 2024
Merged

feat: Add support for Wolfi #672

merged 3 commits into from
Jan 29, 2024

Conversation

EyeCantCU
Copy link
Contributor

This adds support for updating Wolfi via Topgrade

Standards checklist:

  • The PR title is descriptive.
  • I have read CONTRIBUTING.md
  • The code compiles (cargo build)
  • The code passes rustfmt (cargo fmt)
  • The code passes clippy (cargo clippy)
  • The code passes tests (cargo test)
  • Optional: I have tested the code myself

Copy link
Member

@SteveLauC SteveLauC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for contributing to Topgrade, changes LGTM, though I recommend adding

  1. its /etc/os-release file
  2. A unit test on the parsing procedure

BTW, I am collecting Linux distros' os-release file here, would you like to add Wolfi's one to the repo? Much appreciated if you are willing to do it:)

src/steps/os/linux.rs Show resolved Hide resolved
@EyeCantCU
Copy link
Contributor Author

Thanks for the review! I can certainly make those changes here shortly

Copy link
Member

@SteveLauC SteveLauC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! And congratulations on your first contribution to Topgrade!

@SteveLauC SteveLauC merged commit c311da1 into topgrade-rs:main Jan 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants