Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: also detect Helix step with bin name hx #710

Merged
merged 1 commit into from
Feb 22, 2024
Merged

feat: also detect Helix step with bin name hx #710

merged 1 commit into from
Feb 22, 2024

Conversation

SteveLauC
Copy link
Member

Standards checklist:

  • The PR title is descriptive.
  • I have read CONTRIBUTING.md
  • The code compiles (cargo build)
  • The code passes rustfmt (cargo fmt)
  • The code passes clippy (cargo clippy)
  • The code passes tests (cargo test)
  • Optional: I have tested the code myself

The binary name of Helix varies from systems, on my host (Fedora, installed with dnf), it is called hx rather than helix, this PR enables Topgrade to search it with the binary name hx.

@SteveLauC SteveLauC merged commit a43b03d into topgrade-rs:main Feb 22, 2024
9 checks passed
@SteveLauC SteveLauC deleted the feat/helix_step_hx_bin_name branch February 22, 2024 23:42
InnocentZero pushed a commit to InnocentZero/topgrade that referenced this pull request May 25, 2024
@SteveLauC @InnocentZero
feat: also detect Helix step with bin name hx (topgrade-rs#710)
4f02a44
@lucaspar lucaspar mentioned this pull request Jul 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@SteveLauC