Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pipx): adds --include-injected argument to pipx #726

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

ramdomPTM
Copy link
Contributor

Standards checklist:

  • The PR title is descriptive.
  • I have read CONTRIBUTING.md
  • The code compiles (cargo build)
  • The code passes rustfmt (cargo fmt)
  • The code passes clippy (cargo clippy)
  • The code passes tests (cargo test)
  • Optional: I have tested the code myself

This pull request adds --include-injected argument when running pipx upgrade-all, otherwise packages injected into the main apps' environments will not be updated.

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 5.48%. Comparing base (6dab1e4) to head (0e0ae14).

Files Patch % Lines
src/steps/generic.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #726   +/-   ##
=====================================
  Coverage   5.48%   5.48%           
=====================================
  Files         37      37           
  Lines      11860   11860           
=====================================
  Hits         651     651           
  Misses     11209   11209           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@SteveLauC SteveLauC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! And congratulations on your first contribution to Topgrade!

@SteveLauC SteveLauC merged commit fbc84e8 into topgrade-rs:main Mar 1, 2024
18 of 19 checks passed
@ramdomPTM ramdomPTM deleted the pipx-include-injected branch March 1, 2024 07:08
@ramdomPTM ramdomPTM restored the pipx-include-injected branch March 1, 2024 07:08
@ramdomPTM ramdomPTM deleted the pipx-include-injected branch March 1, 2024 07:09
InnocentZero pushed a commit to InnocentZero/topgrade that referenced this pull request May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants