Add support for Lean 4's elan #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveLauC
requested changes
Mar 13, 2024
| @@ -225,6 +227,12 @@ pub fn run_rustup(ctx: &ExecutionContext) -> Result<()> { | |||
|
|
|||
| print_separator("rustup"); | |||
| ctx.run_type().execute(rustup).arg("update").status_checked() | |||
| pub fn run_elan(ctx: &ExecutionContext) -> Result<()> { | |||
There was a problem hiding this comment.
We should add a } for run_rustup() as it seemed to be mistakenly deleted
It's like rustup/juliaup/ghcup/...
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #742 +/- ##
========================================
- Coverage 5.43% 5.37% -0.06%
========================================
Files 37 37
Lines 11988 12119 +131
========================================
Hits 651 651
- Misses 11337 11468 +131 ☔ View full report in Codecov by Sentry. |
SteveLauC
reviewed
Mar 14, 2024
Co-authored-by: SteveLauC <stevelauc@outlook.com>
InnocentZero
pushed a commit
to InnocentZero/topgrade
that referenced
this pull request
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's like rustup/juliaup/ghcup/...