Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always display windows update step #781

Merged
merged 3 commits into from
May 6, 2024
Merged

Always display windows update step #781

merged 3 commits into from
May 6, 2024

Conversation

vzze
Copy link
Contributor

@vzze vzze commented Apr 25, 2024

Standards checklist:

  • The PR title is descriptive.
  • I have read CONTRIBUTING.md
  • The code compiles (cargo build)
  • The code passes rustfmt (cargo fmt)
  • The code passes clippy (cargo clippy)
  • The code passes tests (cargo test)
  • Optional: I have tested the code myself

I was wondering why the Windows Update step disappeared in the newest version, it seems
to be disabled if you don't have the correct powershell module installed, however I think
it is useful for the step to always appear in order to inform the user about the problem.

This is how it looks now:

image

Please ignore changes to CONTRIBUTING.md my auto-formatter removed redundant white-space characters

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 6.51%. Comparing base (614131b) to head (f09be5c).

Files Patch % Lines
src/steps/os/windows.rs 0.00% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #781      +/-   ##
========================================
- Coverage   6.51%   6.51%   -0.01%     
========================================
  Files         37      37              
  Lines      12396   12402       +6     
========================================
  Hits         808     808              
- Misses     11588   11594       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@SteveLauC SteveLauC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think this is better

@SteveLauC SteveLauC merged commit a3428e3 into topgrade-rs:main May 6, 2024
17 of 19 checks passed
InnocentZero pushed a commit to InnocentZero/topgrade that referenced this pull request May 25, 2024
* always display windows update step

* remove extra comma

* i guess format wants the comma
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants