Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 2 clippy warnings #789

Merged
merged 1 commit into from
May 6, 2024
Merged

Conversation

SteveLauC
Copy link
Member

Standards checklist:

  • The PR title is descriptive.
  • I have read CONTRIBUTING.md
  • The code compiles (cargo build)
  • The code passes rustfmt (cargo fmt)
  • The code passes clippy (cargo clippy)
  • The code passes tests (cargo test)
  • Optional: I have tested the code myself

For new steps

  • Optional: Topgrade skips this step where needed
  • Optional: The --dry-run option works with this step
  • Optional: The --yes option works with this step if it is supported by
    the underlying command

If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.


Fix 2 clippy wranings

Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 4.48%. Comparing base (614131b) to head (8a7c9ca).
Report is 1 commits behind head on main.

Files Patch % Lines
src/config.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #789      +/-   ##
========================================
- Coverage   6.51%   4.48%   -2.04%     
========================================
  Files         37      32       -5     
  Lines      12396    5642    -6754     
========================================
- Hits         808     253     -555     
+ Misses     11588    5389    -6199     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SteveLauC SteveLauC merged commit 767f0d9 into topgrade-rs:main May 6, 2024
12 of 19 checks passed
@SteveLauC SteveLauC deleted the refactor/clippy branch May 6, 2024 12:37
InnocentZero pushed a commit to InnocentZero/topgrade that referenced this pull request May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant