Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fedora Sway Atomic should be recognized as FedoraImmutable #795

Merged
merged 2 commits into from
May 11, 2024

Conversation

SteveLauC
Copy link
Member

Standards checklist:

  • The PR title is descriptive.
  • I have read CONTRIBUTING.md
  • The code compiles (cargo build)
  • The code passes rustfmt (cargo fmt)
  • The code passes clippy (cargo clippy)
  • The code passes tests (cargo test)
  • Optional: I have tested the code myself

For new steps

  • Optional: Topgrade skips this step where needed
  • Optional: The --dry-run option works with this step
  • Optional: The --yes option works with this step if it is supported by
    the underlying command

If you developed a feature or a bug fix for someone else and you do not have the
means to test it, please tag this person here.

What does this PR do

Closes #783

Before this PR, Topgrade recognized Fedora Sway Atomic as a normal Fedora distro, which is not correct, it should be FedoraImmutable.

Copy link

codecov bot commented May 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 6.78%. Comparing base (767f0d9) to head (70e3f98).

❗ Current head 70e3f98 differs from pull request most recent head 488db7f. Consider uploading reports for the commit 488db7f to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##            main    #795      +/-   ##
========================================
- Coverage   6.91%   6.78%   -0.14%     
========================================
  Files         37      37              
  Lines      11645   11824     +179     
========================================
- Hits         805     802       -3     
- Misses     10840   11022     +182     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SteveLauC SteveLauC merged commit 4d66431 into topgrade-rs:main May 11, 2024
11 of 17 checks passed
@SteveLauC SteveLauC deleted the fix/sway branch May 11, 2024 03:20
InnocentZero pushed a commit to InnocentZero/topgrade that referenced this pull request May 25, 2024
…rade-rs#795)

* fix: Fedora Sway Atomic should be recognized as FedoraImmutable

* style: fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fedora sway atomic detected as regular
1 participant