Brmsfit method #12
Merged
Brmsfit method #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* address changes to unconstrain_draws in cmdstanr, posterior pareto-k * use posterior github version in workflow * fix workflow deps * fix deprecation warning (topipa#11) * add return_k = TRUE for pareto smoothing * change jacobian_adjustment to jacobian (deprecation warning) --------- Co-authored-by: n-kall <n-kall@github.com> --------- Co-authored-by: n-kall <n-kall@github.com>
topipa
reviewed
Jan 27, 2024
There was a problem hiding this comment.
Thanks for cleaning this up. The problem for me with both my branch and yours is that after running moment matching, accessing the brms fit object returned by moment match gives an error
Error in do.call(cbind, attr(x, "sampler_params")) :
second argument must be a list
Does this happen to you or not?
|
Ah, yes this happens to me too. Seems to be the print method is failing. The object contains the new fit but must be missing something |
|
I now added a function to create dummy The issue is that the |
Oh that was the missing piece. Thank you for taking care of it! The sampler parameters might be useful for something even after moment matching, but we can set them to 0 for now 👍 |
topipa
added a commit
that referenced
this pull request
Mar 31, 2024
* add more methods * add basic brmsfit method * small changes to brmsfit method * add print function * small updates * add return_k = TRUE for pareto smoothing * address changes to unconstrain_draws in cmdstanr, posterior pareto-k * use posterior github version in workflow * fix workflow deps * change jacobian_adjustment to jacobian (deprecation warning) * Posterior updates (#7) * address changes to unconstrain_draws in cmdstanr, posterior pareto-k * use posterior github version in workflow * fix workflow deps * fix deprecation warning (#11) * add return_k = TRUE for pareto smoothing * change jacobian_adjustment to jacobian (deprecation warning) --------- Co-authored-by: n-kall <n-kall@github.com> --------- Co-authored-by: n-kall <n-kall@github.com> * updates to constrain/unconstrain methods * fixes to brmsfit method * docs update * fix namespace warnings * fix namespace issues * add dummy sampler_params function for brmsfit * Brmsfit method (#12) * add return_k = TRUE for pareto smoothing * address changes to unconstrain_draws in cmdstanr, posterior pareto-k * use posterior github version in workflow * fix workflow deps * change jacobian_adjustment to jacobian (deprecation warning) * Posterior updates (#7) * address changes to unconstrain_draws in cmdstanr, posterior pareto-k * use posterior github version in workflow * fix workflow deps * fix deprecation warning (#11) * add return_k = TRUE for pareto smoothing * change jacobian_adjustment to jacobian (deprecation warning) --------- Co-authored-by: n-kall <n-kall@github.com> --------- Co-authored-by: n-kall <n-kall@github.com> * updates to constrain/unconstrain methods * fixes to brmsfit method * docs update * fix namespace warnings * fix namespace issues * add dummy sampler_params function for brmsfit --------- Co-authored-by: n-kall <n-kall@github.com> Co-authored-by: Topi Paananen <24715100+topipa@users.noreply.github.com> * run styler * run styler again * add return statement * no parallel tests by default * document * remove unneeded import * clean blank lines * name log weights appropriately * name log weights * document --------- Co-authored-by: n-kall <n-kall@github.com> Co-authored-by: n-kall <33577035+n-kall@users.noreply.github.com>
n-kall
added a commit
to n-kall/iwmm
that referenced
this pull request
Apr 10, 2024
* add more methods * add basic brmsfit method * small changes to brmsfit method * add print function * small updates * add return_k = TRUE for pareto smoothing * address changes to unconstrain_draws in cmdstanr, posterior pareto-k * use posterior github version in workflow * fix workflow deps * change jacobian_adjustment to jacobian (deprecation warning) * Posterior updates (#7) * address changes to unconstrain_draws in cmdstanr, posterior pareto-k * use posterior github version in workflow * fix workflow deps * fix deprecation warning (topipa#11) * add return_k = TRUE for pareto smoothing * change jacobian_adjustment to jacobian (deprecation warning) --------- --------- * updates to constrain/unconstrain methods * fixes to brmsfit method * docs update * fix namespace warnings * fix namespace issues * add dummy sampler_params function for brmsfit * Brmsfit method (topipa#12) * add return_k = TRUE for pareto smoothing * address changes to unconstrain_draws in cmdstanr, posterior pareto-k * use posterior github version in workflow * fix workflow deps * change jacobian_adjustment to jacobian (deprecation warning) * Posterior updates (#7) * address changes to unconstrain_draws in cmdstanr, posterior pareto-k * use posterior github version in workflow * fix workflow deps * fix deprecation warning (topipa#11) * add return_k = TRUE for pareto smoothing * change jacobian_adjustment to jacobian (deprecation warning) --------- --------- * updates to constrain/unconstrain methods * fixes to brmsfit method * docs update * fix namespace warnings * fix namespace issues * add dummy sampler_params function for brmsfit --------- * run styler * run styler again * add return statement * no parallel tests by default * document * remove unneeded import * clean blank lines * name log weights appropriately * name log weights * document --------- Co-authored-by: Topi Paananen <24715100+topipa@users.noreply.github.com> Co-authored-by: n-kall <n-kall@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates to brmsfit method, passes the tests for me.
Might be still some work to do to clean it up